From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 1/2] ARM: EXYNOS: Add secure firmware support for Exynos5420 Date: Mon, 19 May 2014 13:32:52 +0200 Message-ID: <5379EBE4.9010704@gmail.com> References: <1400497757-18991-1-git-send-email-tushar.behera@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com ([74.125.83.47]:50677 "EHLO mail-ee0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbaESLdC (ORCPT ); Mon, 19 May 2014 07:33:02 -0400 Received: by mail-ee0-f47.google.com with SMTP id c13so3501519eek.34 for ; Mon, 19 May 2014 04:33:00 -0700 (PDT) In-Reply-To: <1400497757-18991-1-git-send-email-tushar.behera@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tushar Behera , linux-samsung-soc@vger.kernel.org Cc: kgene.kim@samsung.com, Sachin Kamat Hi Tushar, Sachin, On 19.05.2014 13:09, Tushar Behera wrote: > From: Sachin Kamat > > Updated secondary boot register offset for Exynos5420 in case of > secure booting. > > Signed-off-by: Sachin Kamat > Signed-off-by: Tushar Behera > --- > > The patches are based on top of next-20140519. With these two patches applied, > we can get all A15 cores booting up on Arndale-Octa board. > > arch/arm/mach-exynos/firmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c > index 739bdc8..5e0902e 100644 > --- a/arch/arm/mach-exynos/firmware.c > +++ b/arch/arm/mach-exynos/firmware.c > @@ -50,7 +50,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr) > > boot_reg = sysram_ns_base_addr + 0x1c; > > - if (!soc_is_exynos4212()) > + if (!soc_is_exynos4212() && !soc_is_exynos5420()) > boot_reg += 4*cpu; I think it is safe to change this simply to if (soc_is_exynos4412()), since this seems to be the only SoC on which the firmware requires this offset. Best regards, Tomasz