From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44382)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WmPgE-0007Hf-29
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:40:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WmPg6-000090-UO
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:40:45 -0400
Received: from cantor2.suse.de ([195.135.220.15]:46215 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WmPg6-00008u-Eq
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:40:38 -0400
Message-ID: <537A25F4.30908@suse.de>
Date: Mon, 19 May 2014 17:40:36 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20140519063132.22955.63563.stgit@bahia.local>
	<5379F2DF.2040909@suse.de> <20140519151008.GA22363@redhat.com>
In-Reply-To: <20140519151008.GA22363@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Juan Quintela <quintela@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <gkurz@linux.vnet.ibm.com>

Am 19.05.2014 17:10, schrieb Michael S. Tsirkin:
> On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote:
>>
>> On 19.05.14 10:38, Greg Kurz wrote:
>>> Hi,
>>>
>>> This patch set tries to address comments from the initial
>>> review. For this round, I have focused on two changes:
>>> - as suggested by Andreas, we now call the device specific
>>>   code from the generic code to ease the implementation of
>>>   future devices. This is achieved with the addition of
>>>   load/save methods to VirtioDeviceClass.
>>> - virtio subsections now implement a "needed" concept with
>>>   the same semantics as in the VMState code.
>>>
>>> I haven't looked at compat mode issues yet, but it is
>>> on my TODO list.
>>
>> If you fix up the comments to be either
>>
>>   /*
>>    * foo
>>    */
>>
>> or
>>
>>   /* foo */
>>
>> style, not
>>
>>   /* foo
>>    */
>>
>> then you get my
>>
>>
>> Acked-by: Alexander Graf <agraf@suse.de>
>>
>>
>> Alex
>=20
> Documented anywhere?
> Linux style is
>=20
>         /* Always
>          * like this.
>          */
>=20
> so it's definitely not universal.

I could've sworn that you (mst) asked at least two people to change
comments from

/* foo
   bar */

to

/*
 * foo
 */

style...

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg