From: David Vrabel <david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
To: Daniel Kiper
<daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org
Cc: boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
eshelton-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
jbeulich-IBi9RG/b67k@public.gmane.org,
jeremy-TSDbQ3PG+2Y@public.gmane.org,
konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org
Subject: Re: [PATCH v4 0/5] xen: Add EFI support
Date: Mon, 19 May 2014 16:53:28 +0100 [thread overview]
Message-ID: <537A28F8.4030707@citrix.com> (raw)
In-Reply-To: <1400272904-31121-1-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On 16/05/14 21:41, Daniel Kiper wrote:
> Hey,
>
> This patch series adds EFI support for Xen dom0 guests.
> It is based on Jan Beulich and Tang Liang work. I was
> trying to take into account all previous comments,
> however, if I missed something sorry for that.
There needs to be a better description of this series. In particular, a
description of why Xen PV guests are different and the overall design used.
> I am still not sure what to do with /sys/firmware/efi/config_table,
> /sys/firmware/efi/{fw_vendor,runtime,systab} files. On bare metal
> they contain physical addresses of relevant structures. However,
> in Xen case they does not make sens. So maybe they should contain
> invalid values (e.g. 0) or should not appear at all on Xen (I prefer
> last one). What do you think about that?
Generally, dom0 has provided access to BIOS provided data structures. I
think you should do the same here. They may be useful for diagnostics
if nothing else.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<x86@kernel.org>, <xen-devel@lists.xenproject.org>
Cc: <boris.ostrovsky@oracle.com>, <eshelton@pobox.com>,
<hpa@zytor.com>, <ian.campbell@citrix.com>, <jbeulich@suse.com>,
<jeremy@goop.org>, <konrad.wilk@oracle.com>,
<matt.fleming@intel.com>, <mingo@redhat.com>,
<mjg59@srcf.ucam.org>, <stefano.stabellini@eu.citrix.com>,
<tglx@linutronix.de>
Subject: Re: [PATCH v4 0/5] xen: Add EFI support
Date: Mon, 19 May 2014 16:53:28 +0100 [thread overview]
Message-ID: <537A28F8.4030707@citrix.com> (raw)
In-Reply-To: <1400272904-31121-1-git-send-email-daniel.kiper@oracle.com>
On 16/05/14 21:41, Daniel Kiper wrote:
> Hey,
>
> This patch series adds EFI support for Xen dom0 guests.
> It is based on Jan Beulich and Tang Liang work. I was
> trying to take into account all previous comments,
> however, if I missed something sorry for that.
There needs to be a better description of this series. In particular, a
description of why Xen PV guests are different and the overall design used.
> I am still not sure what to do with /sys/firmware/efi/config_table,
> /sys/firmware/efi/{fw_vendor,runtime,systab} files. On bare metal
> they contain physical addresses of relevant structures. However,
> in Xen case they does not make sens. So maybe they should contain
> invalid values (e.g. 0) or should not appear at all on Xen (I prefer
> last one). What do you think about that?
Generally, dom0 has provided access to BIOS provided data structures. I
think you should do the same here. They may be useful for diagnostics
if nothing else.
David
next prev parent reply other threads:[~2014-05-19 15:53 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 20:41 [PATCH v4 0/5] xen: Add EFI support Daniel Kiper
2014-05-16 20:41 ` Daniel Kiper
2014-05-16 20:41 ` [PATCH v4 1/5] efi: Introduce EFI_DIRECT flag Daniel Kiper
2014-05-16 20:41 ` Daniel Kiper
2014-05-19 13:30 ` Jan Beulich
2014-05-19 13:30 ` Jan Beulich
2014-05-19 13:30 ` Jan Beulich
[not found] ` <537A23A50200007800013A7F-tRfBTM6QL9aeHWOVceGJHFaTQe2KTcn/@public.gmane.org>
2014-05-19 20:46 ` Daniel Kiper
2014-05-19 20:46 ` Daniel Kiper
2014-05-20 6:16 ` Jan Beulich
2014-05-20 6:16 ` Jan Beulich
2014-05-19 20:46 ` Daniel Kiper
2014-05-19 15:58 ` David Vrabel
2014-05-19 15:58 ` David Vrabel
[not found] ` <537A2A28.4010903-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-05-19 21:02 ` Daniel Kiper
2014-05-19 21:02 ` Daniel Kiper
2014-05-22 7:26 ` Matt Fleming
2014-05-22 7:26 ` Matt Fleming
2014-05-19 21:02 ` Daniel Kiper
2014-05-19 15:58 ` David Vrabel
2014-05-16 20:41 ` [PATCH v4 2/5] xen: Define EFI related stuff Daniel Kiper
2014-05-16 20:41 ` Daniel Kiper
2014-05-19 16:00 ` David Vrabel
[not found] ` <1400272904-31121-3-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-05-19 16:00 ` David Vrabel
2014-05-19 16:00 ` David Vrabel
[not found] ` <1400272904-31121-1-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-05-16 20:41 ` [PATCH v4 3/5] xen: Put EFI machinery in place Daniel Kiper
2014-05-16 20:41 ` Daniel Kiper
2014-05-19 13:39 ` [Xen-devel] " Andrew Cooper
2014-05-19 13:39 ` Andrew Cooper
[not found] ` <537A0974.40302-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-05-19 13:47 ` Jan Beulich
2014-05-19 13:47 ` Jan Beulich
2014-05-19 13:47 ` Jan Beulich
2014-05-19 13:39 ` Andrew Cooper
2014-05-19 13:43 ` Jan Beulich
2014-05-19 13:43 ` Jan Beulich
2014-05-19 13:43 ` Jan Beulich
2014-05-20 9:47 ` David Vrabel
[not found] ` <1400272904-31121-4-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-05-20 9:47 ` David Vrabel
2014-05-20 9:47 ` David Vrabel
[not found] ` <537B2494.2080702-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-05-20 11:29 ` Daniel Kiper
2014-05-20 11:29 ` Daniel Kiper
2014-05-20 11:58 ` Jan Beulich
[not found] ` <20140520112933.GF3529-fJNZiO034lp9pOct4yEdx/3oZC3j2Omk@public.gmane.org>
2014-05-20 11:58 ` Jan Beulich
2014-05-20 11:58 ` Jan Beulich
2014-05-20 12:10 ` David Vrabel
2014-05-20 12:10 ` David Vrabel
2014-05-20 12:10 ` David Vrabel
2014-05-20 11:29 ` Daniel Kiper
2014-05-19 15:53 ` David Vrabel [this message]
2014-05-19 15:53 ` [PATCH v4 0/5] xen: Add EFI support David Vrabel
2014-05-16 20:41 ` [PATCH v4 3/5] xen: Put EFI machinery in place Daniel Kiper
2014-05-16 20:41 ` [PATCH v4 4/5] arch/x86: Replace plain strings with constants Daniel Kiper
2014-05-16 20:41 ` Daniel Kiper
[not found] ` <1400272904-31121-5-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-05-22 7:56 ` Matt Fleming
2014-05-22 7:56 ` Matt Fleming
2014-05-22 7:56 ` Matt Fleming
2014-05-16 20:41 ` [PATCH v4 5/5] arch/x86: Remove redundant set_bit() call Daniel Kiper
2014-05-16 20:41 ` Daniel Kiper
2014-05-22 7:59 ` Matt Fleming
[not found] ` <1400272904-31121-6-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-05-22 7:59 ` Matt Fleming
2014-05-22 7:59 ` Matt Fleming
2014-05-19 15:53 ` [PATCH v4 0/5] xen: Add EFI support David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2014-05-16 20:41 Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A28F8.4030707@citrix.com \
--to=david.vrabel-sxgqhf6nn4dqt0dzr+alfa@public.gmane.org \
--cc=boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=eshelton-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=jbeulich-IBi9RG/b67k@public.gmane.org \
--cc=jeremy-TSDbQ3PG+2Y@public.gmane.org \
--cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.