From: Jens Axboe <axboe@kernel.dk>
To: "xan.peng" <xanpeng@gmail.com>,
daniel.gollub@gmail.com,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Fix a bug of rbd engine when specify invalidate=1 or fadvise_hint=1
Date: Mon, 19 May 2014 13:35:26 -0600 [thread overview]
Message-ID: <537A5CFE.4090800@kernel.dk> (raw)
In-Reply-To: <CA+8ZFngfLhzUopzPznyQ-ZwZgqMuDiEPhUpK5c20HkWNe0nz6w@mail.gmail.com>
On 2014-05-19 11:38, xan.peng wrote:
> When specify invalidate=1 or fadvise_hint=1, fio will call
> posix_fadvise(2), which will return -EBADF and prevent fio librbd
> engine acting normally.
> Here is the call path: ... > td_io_open_file() >
> file_invalidate_cache() > __file_invalidate_cache() > posix_fadvise(fd
> = -1) > ...
>
> The patch work-around this problem by setting file type to
> FIO_TYPE_CHAR in fio_rbd_open().
Might be better to add a new type for this, like FIO_TYPE_SPECIAL or
something. Otherwise we could risk running into other cases, where fio
then thinks it really is a char device.
--
Jens Axboe
next prev parent reply other threads:[~2014-05-19 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 17:38 Fix a bug of rbd engine when specify invalidate=1 or fadvise_hint=1 xan.peng
2014-05-19 19:35 ` Jens Axboe [this message]
2014-05-20 1:32 ` xan.peng
2014-05-20 1:59 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A5CFE.4090800@kernel.dk \
--to=axboe@kernel.dk \
--cc=daniel.gollub@gmail.com \
--cc=fio@vger.kernel.org \
--cc=xanpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.