Re: [PATCH net-next 1/4] net: bcmgenet: use the new fixed PHY helpers

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 05/19/2014 11:43 PM, Florian Fainelli wrote:

> of_phy_connect_fixed_link() is becoming obsolete, and also required
> platform code to register the fixed PHYs at the specified addresses for
> those to be usable. Get rid of it and use the new of_phy_is_fixed_link()
> plus of_phy_register_fixed_link() helpers to transition over the new
> scheme.

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>   drivers/net/ethernet/broadcom/genet/bcmmii.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)

> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index 4608673beaff..69bc69f86638 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
[...]
> @@ -307,15 +308,20 @@ static int bcmgenet_mii_probe(struct net_device *dev)
[...]
> +	phydev = of_phy_connect(dev, priv->phy_dn, bcmgenet_mii_setup, 0,
> +					priv->phy_interface);

    The continuation line is indented incorrectly, you should have started it 
right under 'dev' on the previous line.

WBR, Sergei