From: Anand Jain <Anand.Jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: all super blocks of the replaced disk must be scratched
Date: Tue, 20 May 2014 14:02:15 +0800 [thread overview]
Message-ID: <537AEFE7.5030203@oracle.com> (raw)
In-Reply-To: <20140320182154.GM29256@twin.jikos.cz>
On 21/03/14 02:21, David Sterba wrote:
> On Mon, Mar 17, 2014 at 07:58:06PM +0800, Anand Jain wrote:
>> In a normal scenario when sys-admin replaces a disk, the
>> expeted is btrfs will release the disk completely.
>>
>> However the below test case gives a wrong impression that
>> replaced disk is still is in use.
>>
>> $ btrfs rep start /dev/sde /dev/sdg4 /btrfs
>> $ mkfs.btrfs /dev/sde
>> /dev/sde appears to contain an existing filesystem (btrfs).
>> Error: Use the -f option to force overwrite.
>
> (your signed-off is missing)
>
> Reviewed-by: David Sterba <dsterba@suse.cz>
>
> I've noticed that btrfs_rm_device also cleans only the first superblock
> signature, so it should do the same.
A separate patch was generated for this
btrfs: btrfs_rm_device() should zero mirror SB as well
Thanks, Anand
> I can't think of any drawback where all the superblocks are scratched,
> should be safe.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-05-20 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 11:58 [PATCH] Btrfs: all super blocks of the replaced disk must be scratched Anand Jain
2014-03-20 18:21 ` David Sterba
2014-05-20 6:02 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537AEFE7.5030203@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.