All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev <b43-dev@lists.infradead.org>
Subject: [PATCH] b43: xmit: set 5 GHz bit depending on current band
Date: Tue, 20 May 2014 09:10:35 +0200	[thread overview]
Message-ID: <537AFFEB.1040707@meshcoding.com> (raw)
In-Reply-To: <CACna6rwa6zKX=ngSQhmWTrZcy_W7fjMrTmQ-A8XURZCVMX1nrA@mail.gmail.com>



On 20/05/14 09:09, Rafa? Mi?ecki wrote:
> On 20 May 2014 08:48, Antonio Quartulli <antonio@meshcoding.com> wrote:
>> On 20/05/14 08:46, Rafa? Mi?ecki wrote:
>>> --- a/drivers/net/wireless/b43/xmit.c
>>> +++ b/drivers/net/wireless/b43/xmit.c
>>> -     if (phy->type == B43_PHYTYPE_A)
>>> +     if (!phy->gmode)
>>>               mac_ctl |= B43_TXH_MAC_5GHZ;
>>
>> I am not familiar with this driver, but wouldn't 11b mode fall in this
>> case as well ?
> 
> What Broadcom calls a "gmode" is 2GHz. So this is a simple bool
> 1) gmode = true; // we work in 2GHz mode
> 2) gmode = false; // we work in 5GHz mode

Oh ok, thanks for the clarification! I think the variable name should be
less ambiguous then, but it's your/broadcom code :)

Cheers,


-- 
Antonio Quartulli

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20140520/43f22b5b/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@meshcoding.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev <b43-dev@lists.infradead.org>
Subject: Re: [PATCH] b43: xmit: set 5 GHz bit depending on current band
Date: Tue, 20 May 2014 09:10:35 +0200	[thread overview]
Message-ID: <537AFFEB.1040707@meshcoding.com> (raw)
In-Reply-To: <CACna6rwa6zKX=ngSQhmWTrZcy_W7fjMrTmQ-A8XURZCVMX1nrA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]



On 20/05/14 09:09, Rafał Miłecki wrote:
> On 20 May 2014 08:48, Antonio Quartulli <antonio@meshcoding.com> wrote:
>> On 20/05/14 08:46, Rafał Miłecki wrote:
>>> --- a/drivers/net/wireless/b43/xmit.c
>>> +++ b/drivers/net/wireless/b43/xmit.c
>>> -     if (phy->type == B43_PHYTYPE_A)
>>> +     if (!phy->gmode)
>>>               mac_ctl |= B43_TXH_MAC_5GHZ;
>>
>> I am not familiar with this driver, but wouldn't 11b mode fall in this
>> case as well ?
> 
> What Broadcom calls a "gmode" is 2GHz. So this is a simple bool
> 1) gmode = true; // we work in 2GHz mode
> 2) gmode = false; // we work in 5GHz mode

Oh ok, thanks for the clarification! I think the variable name should be
less ambiguous then, but it's your/broadcom code :)

Cheers,


-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  reply	other threads:[~2014-05-20  7:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  6:46 [PATCH] b43: xmit: set 5 GHz bit depending on current band Rafał Miłecki
2014-05-20  6:46 ` Rafał Miłecki
2014-05-20  6:48 ` Antonio Quartulli
2014-05-20  6:48   ` Antonio Quartulli
2014-05-20  7:09   ` Rafał Miłecki
2014-05-20  7:09     ` Rafał Miłecki
2014-05-20  7:10     ` Antonio Quartulli [this message]
2014-05-20  7:10       ` Antonio Quartulli
2014-05-20  7:23       ` Rafał Miłecki
2014-05-20  7:23         ` Rafał Miłecki
2014-05-20  8:18         ` Michael Büsch
2014-05-20  8:18           ` Michael Büsch
2014-05-20  8:24           ` Rafał Miłecki
2014-05-20  8:24             ` Rafał Miłecki
2014-05-20  7:27 ` [PATCH V2] " Rafał Miłecki
2014-05-20  7:27   ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537AFFEB.1040707@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.