From mboxrd@z Thu Jan 1 00:00:00 1970 From: Madhavan Srinivasan Subject: Re: [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries Date: Tue, 20 May 2014 13:33:58 +0530 Message-ID: <537B0C6E.4030501@linux.vnet.ibm.com> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <1399541296-18810-3-git-send-email-maddy@linux.vnet.ibm.com> <20140520002834.aefb5a90.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140520002834.aefb5a90.akpm@linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Andrew Morton Cc: linux-arch@vger.kernel.org, riel@redhat.com, rusty@rustcorp.com.au, dave.hansen@intel.com, peterz@infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ak@linux.intel.com, paulus@samba.org, mgorman@suse.de, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org, kirill.shutemov@linux.intel.com List-Id: linux-arch.vger.kernel.org T24gVHVlc2RheSAyMCBNYXkgMjAxNCAxMjo1OCBQTSwgQW5kcmV3IE1vcnRvbiB3cm90ZToKPiBP biBUaHUsICA4IE1heSAyMDE0IDE0OjU4OjE2ICswNTMwIE1hZGhhdmFuIFNyaW5pdmFzYW4gPG1h ZGR5QGxpbnV4LnZuZXQuaWJtLmNvbT4gd3JvdGU6Cj4gCj4+IC0tLSBhL2FyY2gvcG93ZXJwYy9w bGF0Zm9ybXMvcHNlcmllcy9wc2VyaWVzLmgKPj4gKysrIGIvYXJjaC9wb3dlcnBjL3BsYXRmb3Jt cy9wc2VyaWVzL3BzZXJpZXMuaAo+PiBAQCAtMTcsNiArMTcsOCBAQCBzdHJ1Y3QgZGV2aWNlX25v ZGU7Cj4+ICBleHRlcm4gdm9pZCByZXF1ZXN0X2V2ZW50X3NvdXJjZXNfaXJxcyhzdHJ1Y3QgZGV2 aWNlX25vZGUgKm5wLAo+PiAgCQkJCSAgICAgICBpcnFfaGFuZGxlcl90IGhhbmRsZXIsIGNvbnN0 IGNoYXIgKm5hbWUpOwo+PiAgCj4+ICtleHRlcm4gdW5zaWduZWQgaW50IGZhdWx0X2Fyb3VuZF9v cmRlcjsKPiAKPiBUaGlzIGlzbid0IGFuIGFwcHJvcHJpYXRlIGhlYWRlciBmaWxlIGZvciBleHBv cnRpbmcgc29tZXRoaW5nIGZyb20gY29yZQo+IG1tIC0gd2hhdCBoYXBwZW5zIGlmIGFyY2gvbW4x MDMwMCB3YW50cyBpdD8uCj4KPiBJIGd1ZXNzIGluY2x1ZGUvbGludXgvbW0uaCBpcyB0aGUgcGxh Y2UuCj4gCgpSdXN0eSBhbHJlYWR5IHN1Z2dlc3RlZCB0aGlzLiBNeSBiYWQuICBSZWFzb24gZm9y IGFkZGluZyBpdCBoZXJlIHdhcwp0aGF0LCBJIGRpZCB0aGUgcGVyZm9ybWFuY2UgdGVzdCBmb3Ig dGhpcyBwbGF0Zm9ybS4gV2lsbCBjaGFuZ2UgYW5kIHNlbmQKaXQgb3V0LgoKVGhhbmtzIGZvciBy ZXZpZXcKUmVnYXJkcwpNYWRkeQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMu b3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp05.in.ibm.com ([122.248.162.5]:50228 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752240AbaETIEI (ORCPT ); Tue, 20 May 2014 04:04:08 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 May 2014 13:34:05 +0530 Message-ID: <537B0C6E.4030501@linux.vnet.ibm.com> Date: Tue, 20 May 2014 13:33:58 +0530 From: Madhavan Srinivasan MIME-Version: 1.0 Subject: Re: [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <1399541296-18810-3-git-send-email-maddy@linux.vnet.ibm.com> <20140520002834.aefb5a90.akpm@linux-foundation.org> In-Reply-To: <20140520002834.aefb5a90.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com Message-ID: <20140520080358.xL4x9GIqshgB7edJvzHYb4ldZc4XCzgU_ZuNbxFp-OI@z> On Tuesday 20 May 2014 12:58 PM, Andrew Morton wrote: > On Thu, 8 May 2014 14:58:16 +0530 Madhavan Srinivasan wrote: > >> --- a/arch/powerpc/platforms/pseries/pseries.h >> +++ b/arch/powerpc/platforms/pseries/pseries.h >> @@ -17,6 +17,8 @@ struct device_node; >> extern void request_event_sources_irqs(struct device_node *np, >> irq_handler_t handler, const char *name); >> >> +extern unsigned int fault_around_order; > > This isn't an appropriate header file for exporting something from core > mm - what happens if arch/mn10300 wants it?. > > I guess include/linux/mm.h is the place. > Rusty already suggested this. My bad. Reason for adding it here was that, I did the performance test for this platform. Will change and send it out. Thanks for review Regards Maddy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp09.in.ibm.com (e28smtp09.in.ibm.com [122.248.162.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 078181A0852 for ; Tue, 20 May 2014 18:04:06 +1000 (EST) Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 May 2014 13:34:03 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id C192A125804D for ; Tue, 20 May 2014 13:33:08 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4K84Cu1196912 for ; Tue, 20 May 2014 13:34:12 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4K840nC023115 for ; Tue, 20 May 2014 13:34:01 +0530 Message-ID: <537B0C6E.4030501@linux.vnet.ibm.com> Date: Tue, 20 May 2014 13:33:58 +0530 From: Madhavan Srinivasan MIME-Version: 1.0 To: Andrew Morton Subject: Re: [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <1399541296-18810-3-git-send-email-maddy@linux.vnet.ibm.com> <20140520002834.aefb5a90.akpm@linux-foundation.org> In-Reply-To: <20140520002834.aefb5a90.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-arch@vger.kernel.org, riel@redhat.com, rusty@rustcorp.com.au, dave.hansen@intel.com, peterz@infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ak@linux.intel.com, paulus@samba.org, mgorman@suse.de, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org, kirill.shutemov@linux.intel.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday 20 May 2014 12:58 PM, Andrew Morton wrote: > On Thu, 8 May 2014 14:58:16 +0530 Madhavan Srinivasan wrote: > >> --- a/arch/powerpc/platforms/pseries/pseries.h >> +++ b/arch/powerpc/platforms/pseries/pseries.h >> @@ -17,6 +17,8 @@ struct device_node; >> extern void request_event_sources_irqs(struct device_node *np, >> irq_handler_t handler, const char *name); >> >> +extern unsigned int fault_around_order; > > This isn't an appropriate header file for exporting something from core > mm - what happens if arch/mn10300 wants it?. > > I guess include/linux/mm.h is the place. > Rusty already suggested this. My bad. Reason for adding it here was that, I did the performance test for this platform. Will change and send it out. Thanks for review Regards Maddy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by kanga.kvack.org (Postfix) with ESMTP id 1DBFB6B0036 for ; Tue, 20 May 2014 04:04:08 -0400 (EDT) Received: by mail-pa0-f47.google.com with SMTP id lf10so90507pab.34 for ; Tue, 20 May 2014 01:04:07 -0700 (PDT) Received: from e28smtp03.in.ibm.com (e28smtp03.in.ibm.com. [122.248.162.3]) by mx.google.com with ESMTPS id bu1si653109pbc.136.2014.05.20.01.04.06 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 20 May 2014 01:04:07 -0700 (PDT) Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 May 2014 13:34:04 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 666FA1258054 for ; Tue, 20 May 2014 13:33:08 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4K84P5v55509138 for ; Tue, 20 May 2014 13:34:25 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4K840n6023115 for ; Tue, 20 May 2014 13:34:01 +0530 Message-ID: <537B0C6E.4030501@linux.vnet.ibm.com> Date: Tue, 20 May 2014 13:33:58 +0530 From: Madhavan Srinivasan MIME-Version: 1.0 Subject: Re: [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <1399541296-18810-3-git-send-email-maddy@linux.vnet.ibm.com> <20140520002834.aefb5a90.akpm@linux-foundation.org> In-Reply-To: <20140520002834.aefb5a90.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com On Tuesday 20 May 2014 12:58 PM, Andrew Morton wrote: > On Thu, 8 May 2014 14:58:16 +0530 Madhavan Srinivasan wrote: > >> --- a/arch/powerpc/platforms/pseries/pseries.h >> +++ b/arch/powerpc/platforms/pseries/pseries.h >> @@ -17,6 +17,8 @@ struct device_node; >> extern void request_event_sources_irqs(struct device_node *np, >> irq_handler_t handler, const char *name); >> >> +extern unsigned int fault_around_order; > > This isn't an appropriate header file for exporting something from core > mm - what happens if arch/mn10300 wants it?. > > I guess include/linux/mm.h is the place. > Rusty already suggested this. My bad. Reason for adding it here was that, I did the performance test for this platform. Will change and send it out. Thanks for review Regards Maddy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org