Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

["Zhu, Lejun" <lejun.zhu@linux.intel.com>]

On 5/19/2014 10:13 PM, Mathias Nyman wrote:
> On 05/19/2014 03:27 AM, Zhu, Lejun wrote:
>>
>>
>> On 5/17/2014 1:33 AM, Linus Walleij wrote:
>>> On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun <lejun.zhu@linux.intel.com> wrote:
>>>
>>>> Devices based on Intel SoC products such as Baytrail have a Power
>>>> Management IC. In the PMIC there are subsystems for voltage regulation,
>>>> A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called
>>>> Crystal Cove.
>>>>
>>>> This patch adds support for the GPIO function in Crystal Cove.
>>>>
>>>> Signed-off-by: Yang, Bin <bin.yang@intel.com>
>>>> Signed-off-by: Zhu, Lejun <lejun.zhu@linux.intel.com>
>>>
>>> (...)
>>>
>>>> +config GPIO_INTEL_SOC_PMIC
>>>> +       bool "GPIO on Intel SoC PMIC"
>>>> +       depends on INTEL_SOC_PMIC
>>
>> Thank you. That's a long list and all of them indeed need to be fixed.
>> I'll work on them and submit v2 when ready.
>>
> 
> Shouldn't there be a .remove function undoing everything probe did?
> Freeing interrupts, removing irq domains, calling gpiochip_remove etc.
> 
> Or is there something I'm missing?
> I see there's no option to compile this as module, but It might be added later so
> proper remove function would still be nice.
> 
> -Mathias
> 

Good suggestion. I'll fix it. Thanks.

Best Regards
Lejun