From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 02/18] drm/exynos: use wait_event_timeout() for safety usage Date: Tue, 20 May 2014 11:51:35 +0200 Message-ID: <537B25A7.30805@samsung.com> References: <1400048825-6052-1-git-send-email-yj44.cho@samsung.com> <1400048825-6052-3-git-send-email-yj44.cho@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1400048825-6052-3-git-send-email-yj44.cho@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YoungJun Cho , airlied@linux.ie, dri-devel@lists.freedesktop.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, sw0312.kim@samsung.com, kyungmin.park@samsung.com, robh+dt@kernel.org, laurent.pinchart@ideasonboard.com, galak@codeaurora.org, kgene.kim@samsung.com, s.trumtrar@pengutronix.de List-Id: linux-samsung-soc@vger.kernel.org On 05/14/2014 08:26 AM, YoungJun Cho wrote: > There could be the case that the page flip operation isn't finished correctly > with some abnormal condition such as panel reset. So this patch replaces > wait_event() with wait_event_timeout() to avoid waiting for page flip completion > infinitely. > > Signed-off-by: YoungJun Cho > Acked-by: Inki Dae > Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > index 95c9435..485fa26 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > @@ -69,8 +69,9 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) > > if (mode > DRM_MODE_DPMS_ON) { > /* wait for the completion of page flip. */ > - wait_event(exynos_crtc->pending_flip_queue, > - atomic_read(&exynos_crtc->pending_flip) == 0); > + wait_event_timeout(exynos_crtc->pending_flip_queue, > + !atomic_read(&exynos_crtc->pending_flip), > + HZ/20); > drm_vblank_off(crtc->dev, exynos_crtc->pipe); > } >