From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 20 May 2014 10:02:22 +0000 Subject: Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO Message-Id: <537B282E.6040107@suse.de> List-Id: References: <1400040722-29608-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400040722-29608-4-git-send-email-gwshan@linux.vnet.ibm.com> <1400538790.3289.305.camel@ul30vt.home> <20140520002208.GA11073@shangw> <1400546244.3289.341.camel@ul30vt.home> <20140520082856.GA16050@shangw> In-Reply-To: <20140520082856.GA16050@shangw> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Gavin Shan , Alex Williamson Cc: aik@ozlabs.ru, qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org On 20.05.14 10:28, Gavin Shan wrote: > On Mon, May 19, 2014 at 06:37:24PM -0600, Alex Williamson wrote: >> On Tue, 2014-05-20 at 10:22 +1000, Gavin Shan wrote: >>> On Mon, May 19, 2014 at 04:33:10PM -0600, Alex Williamson wrote: >>>> On Wed, 2014-05-14 at 14:11 +1000, Gavin Shan wrote: >>>>> The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container >>>>> to support EEH functionality for PCI devices, which have been >>>>> passed from host to guest via VFIO. [...] >>> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h >>> index cb9023d..1fd1bfb 100644 >>> --- a/include/uapi/linux/vfio.h >>> +++ b/include/uapi/linux/vfio.h >>> @@ -455,6 +455,63 @@ struct vfio_iommu_spapr_tce_info { >>> >>> #define VFIO_IOMMU_SPAPR_TCE_GET_INFO _IO(VFIO_TYPE, VFIO_BASE + 12) >>> >>> +/* >>> + * The VFIO EEH info struct provides way to support EEH functionality >>> + * for PCI device that is passed from host to guest via VFIO. >>> + */ >>> +#define VFIO_EEH_OP_MAP 0 >>> +#define VFIO_EEH_OP_UNMAP 1 >>> +#define VFIO_EEH_OP_SET_OPTION 2 >>> +#define VFIO_EEH_OP_GET_ADDR 3 >>> +#define VFIO_EEH_OP_GET_STATE 4 >>> +#define VFIO_EEH_OP_PE_RESET 5 >>> +#define VFIO_EEH_OP_PE_CONFIG 6 >>>> Is this really an "info" ioctl? >>>> >>> Yeah, "VFIO_EEH_INFO" isn't a good name. How about to have "VFIO_EEH_HANDLER" ? >> VFIO_EEH_OP perhaps. Thanks, >> > Ok. Will rename it to VFIO_EEH_OP in next revision. Is there any benefit of a multiplexing EEH ioctl over just 7 individual ioctls? Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1F9C61A082B for ; Tue, 20 May 2014 20:02:29 +1000 (EST) Message-ID: <537B282E.6040107@suse.de> Date: Tue, 20 May 2014 12:02:22 +0200 From: Alexander Graf MIME-Version: 1.0 To: Gavin Shan , Alex Williamson Subject: Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO References: <1400040722-29608-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400040722-29608-4-git-send-email-gwshan@linux.vnet.ibm.com> <1400538790.3289.305.camel@ul30vt.home> <20140520002208.GA11073@shangw> <1400546244.3289.341.camel@ul30vt.home> <20140520082856.GA16050@shangw> In-Reply-To: <20140520082856.GA16050@shangw> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: aik@ozlabs.ru, qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 20.05.14 10:28, Gavin Shan wrote: > On Mon, May 19, 2014 at 06:37:24PM -0600, Alex Williamson wrote: >> On Tue, 2014-05-20 at 10:22 +1000, Gavin Shan wrote: >>> On Mon, May 19, 2014 at 04:33:10PM -0600, Alex Williamson wrote: >>>> On Wed, 2014-05-14 at 14:11 +1000, Gavin Shan wrote: >>>>> The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container >>>>> to support EEH functionality for PCI devices, which have been >>>>> passed from host to guest via VFIO. [...] >>> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h >>> index cb9023d..1fd1bfb 100644 >>> --- a/include/uapi/linux/vfio.h >>> +++ b/include/uapi/linux/vfio.h >>> @@ -455,6 +455,63 @@ struct vfio_iommu_spapr_tce_info { >>> >>> #define VFIO_IOMMU_SPAPR_TCE_GET_INFO _IO(VFIO_TYPE, VFIO_BASE + 12) >>> >>> +/* >>> + * The VFIO EEH info struct provides way to support EEH functionality >>> + * for PCI device that is passed from host to guest via VFIO. >>> + */ >>> +#define VFIO_EEH_OP_MAP 0 >>> +#define VFIO_EEH_OP_UNMAP 1 >>> +#define VFIO_EEH_OP_SET_OPTION 2 >>> +#define VFIO_EEH_OP_GET_ADDR 3 >>> +#define VFIO_EEH_OP_GET_STATE 4 >>> +#define VFIO_EEH_OP_PE_RESET 5 >>> +#define VFIO_EEH_OP_PE_CONFIG 6 >>>> Is this really an "info" ioctl? >>>> >>> Yeah, "VFIO_EEH_INFO" isn't a good name. How about to have "VFIO_EEH_HANDLER" ? >> VFIO_EEH_OP perhaps. Thanks, >> > Ok. Will rename it to VFIO_EEH_OP in next revision. Is there any benefit of a multiplexing EEH ioctl over just 7 individual ioctls? Alex