From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 20 May 2014 11:28:40 +0000 Subject: Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO Message-Id: <537B3C68.8080102@suse.de> List-Id: References: <1400574612-19411-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400574612-19411-4-git-send-email-gwshan@linux.vnet.ibm.com> <537B3AA7.7040106@suse.de> In-Reply-To: <537B3AA7.7040106@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Gavin Shan , kvm-ppc@vger.kernel.org Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org On 20.05.14 13:21, Alexander Graf wrote: > > On 20.05.14 10:30, Gavin Shan wrote: >> The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device >> to support EEH functionality for PCI devices, which have been >> passed from host to guest via VFIO. >> >> Signed-off-by: Gavin Shan >> --- >> arch/powerpc/platforms/powernv/Makefile | 1 + >> arch/powerpc/platforms/powernv/eeh-vfio.c | 445 >> ++++++++++++++++++++++++++++++ >> drivers/vfio/pci/vfio_pci.c | 24 +- >> drivers/vfio/pci/vfio_pci_private.h | 16 ++ >> include/uapi/linux/vfio.h | 43 +++ >> 5 files changed, 523 insertions(+), 6 deletions(-) >> create mode 100644 arch/powerpc/platforms/powernv/eeh-vfio.c > > Why doesn't this code live inside the vfio module? If I don't load the > vfio module, I don't need that code to waste memory in my kernel, no? So I think from a modeling point of view, you want VFIO code that calls reasonably generic helpers inside the kernel to deal with errors. The "generic helpers" don't have anything to do with VFIO. Everything that interfaces via ioctls with user space is 100% VFIO code. The latter should be tristate inside vfio.ko, the former can be =y. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 989B01A0883 for ; Tue, 20 May 2014 21:28:45 +1000 (EST) Message-ID: <537B3C68.8080102@suse.de> Date: Tue, 20 May 2014 13:28:40 +0200 From: Alexander Graf MIME-Version: 1.0 To: Gavin Shan , kvm-ppc@vger.kernel.org Subject: Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO References: <1400574612-19411-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400574612-19411-4-git-send-email-gwshan@linux.vnet.ibm.com> <537B3AA7.7040106@suse.de> In-Reply-To: <537B3AA7.7040106@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 20.05.14 13:21, Alexander Graf wrote: > > On 20.05.14 10:30, Gavin Shan wrote: >> The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device >> to support EEH functionality for PCI devices, which have been >> passed from host to guest via VFIO. >> >> Signed-off-by: Gavin Shan >> --- >> arch/powerpc/platforms/powernv/Makefile | 1 + >> arch/powerpc/platforms/powernv/eeh-vfio.c | 445 >> ++++++++++++++++++++++++++++++ >> drivers/vfio/pci/vfio_pci.c | 24 +- >> drivers/vfio/pci/vfio_pci_private.h | 16 ++ >> include/uapi/linux/vfio.h | 43 +++ >> 5 files changed, 523 insertions(+), 6 deletions(-) >> create mode 100644 arch/powerpc/platforms/powernv/eeh-vfio.c > > Why doesn't this code live inside the vfio module? If I don't load the > vfio module, I don't need that code to waste memory in my kernel, no? So I think from a modeling point of view, you want VFIO code that calls reasonably generic helpers inside the kernel to deal with errors. The "generic helpers" don't have anything to do with VFIO. Everything that interfaces via ioctls with user space is 100% VFIO code. The latter should be tristate inside vfio.ko, the former can be =y. Alex