From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
Qiao Nuohan <qiaonuohan@cn.fujitsu.com>,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)
Date: Tue, 20 May 2014 14:56:15 +0200 [thread overview]
Message-ID: <537B50EF.6090108@redhat.com> (raw)
In-Reply-To: <1400585987-6285-1-git-send-email-lersek@redhat.com>
Il 20/05/2014 13:39, Laszlo Ersek ha scritto:
> In March Paolo and Luiz had some comments for upstream qemu while they
> were reviewing my downstream port of Qiao Nuohan's compressed
> (kdump-format) dump feature. I've finally got around addressing them.
>
> Laszlo Ersek (7):
> dump: fill in the flat header signature more pleasingly to the eye
> dump: simplify write_start_flat_header()
> dump: eliminate DumpState.page_shift ("guest's page shift")
> dump: eliminate DumpState.page_size ("guest's page size")
> dump: select header bitness based on ELF class, not ELF architecture
> dump: hoist lzo_init() from get_len_buf_out() to dump_init()
> dump: simplify get_len_buf_out()
>
> include/sysemu/dump.h | 8 +--
> dump.c | 142 ++++++++++++++++++++++----------------------------
> 2 files changed, 65 insertions(+), 85 deletions(-)
>
I would have a slight preference for QEMU_BUILD_BUG_ON instead of MIN in
patch 1, but that's a really minor nit.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2014-05-20 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 11:39 [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps) Laszlo Ersek
2014-05-20 11:39 ` [Qemu-devel] [PATCH 3/7] dump: eliminate DumpState.page_shift ("guest's page shift") Laszlo Ersek
2014-05-20 11:39 ` [Qemu-devel] [PATCH 4/7] dump: eliminate DumpState.page_size ("guest's page size") Laszlo Ersek
2014-05-20 11:39 ` [Qemu-devel] [PATCH 5/7] dump: select header bitness based on ELF class, not ELF architecture Laszlo Ersek
2014-05-20 11:42 ` [Qemu-devel] [PATCH 6/7] dump: hoist lzo_init() from get_len_buf_out() to dump_init() Laszlo Ersek
2014-05-20 11:42 ` [Qemu-devel] [PATCH 7/7] dump: simplify get_len_buf_out() Laszlo Ersek
2014-05-20 12:56 ` Paolo Bonzini [this message]
2014-05-20 13:03 ` [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps) Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B50EF.6090108@redhat.com \
--to=pbonzini@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.