Re: libcacard is been installed to /usr/lib while libdir=/usr/lib64

[Zhigang Wang <zhigang.x.wang@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 2330 bytes --]

On 05/20/2014 08:40 AM, Ian Campbell wrote:
> On Thu, 2014-05-15 at 11:54 -0400, Zhigang Wang wrote:
>> On 05/15/2014 11:10 AM, Ian Campbell wrote:
>>> On Mon, 2014-05-12 at 20:10 -0400, Zhigang Wang wrote:
>>>> Is this expected? I thought it should be installed into
>>>> /usr/lib64 as all other xen libs.
>>> 
>>> I think it depends on how you configured the Xen build -- what
>>> options did you use?
>>> 
>>>> Attached patch will change the behavior. Apply it if you think
>>>> it's what we want.
>>> 
>>> I think it probably is but I'll wait for confirmation of the
>>> options you used.
>> 
>> I think the problem is simple as this:
>> 
>> For xen:
>> 
>> ./configure --prefix=/usr --libdir=/usr/lib64
>> 
>> For qemu: we didn't pass the --libdir when we configure it, so it
>> uses the default one: $PREFIX/lib
> 
> Thanks. I think your patch is probably the correct one then. Please
> can you submit with a proper changelog.
> 
>> I use RPM %configure macro, and it translates to:
>> 
>> + ./configure --build=x86_64-redhat-linux-gnu
>> --host=x86_64-redhat-linux-gnu --target=x86_64-redhat-linux-gnu
>> --program-prefix= --prefix=/usr --exec-prefix=/usr
>> --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc
>> --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64
>> --libexecdir=/usr/libexec --localstatedir=/var
>> --sharedstatedir=/var/lib --mandir=/usr/share/man
>> --infodir=/usr/share/info
>> 
>> There are many other options has the same issue: they may different
>> for qemu and xen. I'm not sure what is the best way to handle it.
> 
> I wonder if we should be arranging to pass the full set of configure 
> optons we received down to the subconfigure. That's how projects
> which have subtree configures do things (including our own toplevel,
> tools, docs, stubdom configure). My concern would be that this is a
> 3rd party configure so the scenario is slightly different. TBH I'm no
> autoconf expert so I don't know...
> 
> Ian.
> 

Attached is the patch with some changelog.

Before we can think out the right way to pass all options, I think passing
prefix and libdir is good enough for now:

1. prefix is most widely used.
2. libdir becomes important as x86 and x86_64 get into the same system.
3. Default values for other options seems the same across build systems.

Thanks,

Zhigang

[-- Attachment #2: ovs-xen-qemu-upstream-libdir.patch --]
[-- Type: text/x-patch, Size: 773 bytes --]

tools: pass --libdir to qemu configure

On an x86_64 environment, when we configure xen using:

  ./configure --prefix=/usr --libdir=/usr/lib64
  
only --prefix=/usr is passed to qemu configure. Then qemu will use
$(PREFIX)/lib as libdir, which causes inconsistent with other xen tools.

Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>
diff --git a/tools/Makefile b/tools/Makefile
index 3675515..93c79e7 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -188,6 +188,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
 	$$source/configure --enable-xen --target-list=i386-softmmu \
 		$(QEMU_XEN_ENABLE_DEBUG) \
 		--prefix=$(PREFIX) \
+		--libdir=$(LIBDIR) \
 		--source-path=$$source \
 		--extra-cflags="-I$(XEN_ROOT)/tools/include \
 		-I$(XEN_ROOT)/tools/libxc \

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel