From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WmjhR-000761-Ln
	for qemu-devel@nongnu.org; Tue, 20 May 2014 09:03:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WmjhL-0003Ko-I4
	for qemu-devel@nongnu.org; Tue, 20 May 2014 09:03:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64456)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WmjhL-0003KS-Af
	for qemu-devel@nongnu.org; Tue, 20 May 2014 09:03:15 -0400
Message-ID: <537B5289.6010306@redhat.com>
Date: Tue, 20 May 2014 15:03:05 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1400585987-6285-1-git-send-email-lersek@redhat.com>
	<537B50EF.6090108@redhat.com>
In-Reply-To: <537B50EF.6090108@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Qiao Nuohan <qiaonuohan@cn.fujitsu.com>, Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>

On 05/20/14 14:56, Paolo Bonzini wrote:
> Il 20/05/2014 13:39, Laszlo Ersek ha scritto:
>> In March Paolo and Luiz had some comments for upstream qemu while they
>> were reviewing my downstream port of Qiao Nuohan's compressed
>> (kdump-format) dump feature. I've finally got around addressing them.
>>
>> Laszlo Ersek (7):
>>   dump: fill in the flat header signature more pleasingly to the eye
>>   dump: simplify write_start_flat_header()
>>   dump: eliminate DumpState.page_shift ("guest's page shift")
>>   dump: eliminate DumpState.page_size ("guest's page size")
>>   dump: select header bitness based on ELF class, not ELF architecture
>>   dump: hoist lzo_init() from get_len_buf_out() to dump_init()
>>   dump: simplify get_len_buf_out()
>>
>>  include/sysemu/dump.h |   8 +--
>>  dump.c                | 142
>> ++++++++++++++++++++++----------------------------
>>  2 files changed, 65 insertions(+), 85 deletions(-)
>>
> 
> I would have a slight preference for QEMU_BUILD_BUG_ON instead of MIN in
> patch 1, but that's a really minor nit.
> 
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks! Should I have to respin for any reason, I'll incorporate your
suggestion.

Laszlo