From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balaji T K Subject: Re: [PATCH v2 6/6] mmc: omap_hsmmc: split omap-dma header file Date: Tue, 20 May 2014 18:58:19 +0530 Message-ID: <537B5873.5010006@ti.com> References: <1399654013-28262-1-git-send-email-balajitk@ti.com> <1399654013-28262-7-git-send-email-balajitk@ti.com> <20140516214116.GM12881@atomide.com> <5379F0C6.6070004@ti.com> <20140519165441.GI4849@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:54696 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128AbaETN2b (ORCPT ); Tue, 20 May 2014 09:28:31 -0400 In-Reply-To: <20140519165441.GI4849@atomide.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Tony Lindgren Cc: linux-mmc@vger.kernel.org, chris@printf.net, ulf.hansson@linaro.org, linux-omap@vger.kernel.org, Russell King - ARM Linux On Monday 19 May 2014 10:24 PM, Tony Lindgren wrote: > * Balaji T K [140519 04:54]: >> On Saturday 17 May 2014 03:11 AM, Tony Lindgren wrote: >>>> - >>>> -#if defined(CONFIG_DMA_OMAP) || defined(CONFIG_DMA_OMAP_MODULE) >>>> -bool omap_dma_filter_fn(struct dma_chan *, void *); >>>> -#else >>>> -static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) >>>> -{ >>>> - return false; >>>> -} >>>> -#endif >>>> +#include >>> >>> Can't the drivers needing this include it directly? >>> >> >> Yes, I have converted omap_hsmmc as part of this patch. >> Due to lack of bandwidth, I haven't touched upon all other drivers that include >> omap-dma.h. Once that is done in other subsystem after this patch gets merged, >> this include can then be removed from omap-dma.h > > OK > >>> Also, has this been tested with make randconfig? Changes like >>> this can easily cause problems elsewhere.. >> >> May be I am missing something, Can you please elaborate ? > > You're touching a header included in many places, so you > need to make sure you're not accidentally breaking anything. > True > There's an option that allows you to specify some selected > options like CONFIG_ARCH_OMAP2PLUS=y with KCONFIG_ALLCONFIG > and then run make randconfig. This should expose quite fast > if there are some issues for the other drivers. > > Also, have you compile tested this with omap1_defconfig? > checked omap1_defconfig and randconfig's, both are OK. Thanks and Regards, Balaji T K