All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] at91: DT for 3.16 #2
Date: Tue, 20 May 2014 17:19:24 +0200	[thread overview]
Message-ID: <537B727C.5080404@atmel.com> (raw)
In-Reply-To: <20140520055041.GO18956@quad.lixom.net>

On 20/05/2014 07:50, Olof Johansson :
> On Wed, May 14, 2014 at 11:19:22AM +0200, Nicolas Ferre wrote:
>> Arnd, Olof, Kevin,
>>
>> More DT material for AT91. Some fixes that apply on what was merged for 3.15
>> but that are not very critical.
>> The other patches are feature additions to old or very recent product/board:
>> at91sam9261 or sama5d3 Xplained.
>>
>> Thanks, best regards,
>>
>> The following changes since commit 27a96a0364787d2b41d2a72d08143d95263e1b07:
>>
>>   ARM: at91: sama5d3: clock for ssc from rk pin (2014-04-18 22:43:44 +0200)
>>
>> are available in the git repository at:
>>
>>   git://github.com/at91linux/linux-at91.git tags/at91-dt2
>>
>> for you to fetch changes up to a93f9c88b7701d1c4c3b22d39d64a408f000a6ef:
>>
>>   ARM: at91/dt: at91-sama5d3_xplained: add the regulator device node (2014-05-12 16:48:54 +0200)
> 
> Merged, but:
> 
>>  arch/arm/boot/dts/at91-sama5d3_xplained.dts |  62 +++++++++++++++
>>  arch/arm/boot/dts/at91sam9261.dtsi          | 114 ++++++++++++++++++++++++++--
>>  arch/arm/boot/dts/at91sam9rl.dtsi           |   7 +-
>>  arch/arm/boot/dts/sama5d3.dtsi              |  78 +++++++++++++++++++
> 
> Grmbl. I remember being somewhat annoyed that you didn't use at91 prefix
> when you introduced the sama5d3 dtsi files, but please don't start using
> it on a random board like this, especially when other boards just use
> the sama5d3_<board>.dts format.

Well, I don't understand completely. Since our discussion during 3.10
merge window ([GIT PULL] at91: DT changes for 3.10 #2), I try to conform
to this rule:

1/ all pre-3.10 and 3.10 device tree file names stay unchanged
-> sama5d3.dti (SoC)
-> sama5d35ek.dts (board)

2/ all *SoC* DT files conform to their marking:
at91sam9263.dtsi
at91sam9rl.dtsi
sama5d3.dtsi, sama5d36.dtsi
sama5d4.dtsi, sama5d46.dtsi (maybe in the future, who knows...)

3/ all post-3.10 *boards* have the "at91-" prefix, whether they are
populated with sam9 or sama5:
at91-ariag25.dts (since 3.10, using a at91sam9g25)
at91-qil_a9260.dts (since 3.14, using at91sam9260)
at91-sama5d3_xplained.dts (since 3.14, using sama5d36)

The rule for AT91 has never been to prefix the board DT filename with
the name of the SoC or SoC family.

> Care to fix this up in time for 3.16 merge window?

Well, I do not know what to fix as the files were already present in
mainline before this kernel revision and that I am a little bit
reluctant to change file names after they are merged in mainline.

Now, can we keep the current policy described above (somehow weird, I
admit) for future SoCs and boards?

Best regards,
-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Olof Johansson <olof@lixom.net>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Arnd Bergmann <arnd@arndb.de>, <arm@kernel.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Wenyou Yang <wenyou.yang@atmel.com>,
	"Ludovic Desroches" <ludovic.desroches@atmel.com>
Subject: Re: [GIT PULL] at91: DT for 3.16 #2
Date: Tue, 20 May 2014 17:19:24 +0200	[thread overview]
Message-ID: <537B727C.5080404@atmel.com> (raw)
In-Reply-To: <20140520055041.GO18956@quad.lixom.net>

On 20/05/2014 07:50, Olof Johansson :
> On Wed, May 14, 2014 at 11:19:22AM +0200, Nicolas Ferre wrote:
>> Arnd, Olof, Kevin,
>>
>> More DT material for AT91. Some fixes that apply on what was merged for 3.15
>> but that are not very critical.
>> The other patches are feature additions to old or very recent product/board:
>> at91sam9261 or sama5d3 Xplained.
>>
>> Thanks, best regards,
>>
>> The following changes since commit 27a96a0364787d2b41d2a72d08143d95263e1b07:
>>
>>   ARM: at91: sama5d3: clock for ssc from rk pin (2014-04-18 22:43:44 +0200)
>>
>> are available in the git repository at:
>>
>>   git://github.com/at91linux/linux-at91.git tags/at91-dt2
>>
>> for you to fetch changes up to a93f9c88b7701d1c4c3b22d39d64a408f000a6ef:
>>
>>   ARM: at91/dt: at91-sama5d3_xplained: add the regulator device node (2014-05-12 16:48:54 +0200)
> 
> Merged, but:
> 
>>  arch/arm/boot/dts/at91-sama5d3_xplained.dts |  62 +++++++++++++++
>>  arch/arm/boot/dts/at91sam9261.dtsi          | 114 ++++++++++++++++++++++++++--
>>  arch/arm/boot/dts/at91sam9rl.dtsi           |   7 +-
>>  arch/arm/boot/dts/sama5d3.dtsi              |  78 +++++++++++++++++++
> 
> Grmbl. I remember being somewhat annoyed that you didn't use at91 prefix
> when you introduced the sama5d3 dtsi files, but please don't start using
> it on a random board like this, especially when other boards just use
> the sama5d3_<board>.dts format.

Well, I don't understand completely. Since our discussion during 3.10
merge window ([GIT PULL] at91: DT changes for 3.10 #2), I try to conform
to this rule:

1/ all pre-3.10 and 3.10 device tree file names stay unchanged
-> sama5d3.dti (SoC)
-> sama5d35ek.dts (board)

2/ all *SoC* DT files conform to their marking:
at91sam9263.dtsi
at91sam9rl.dtsi
sama5d3.dtsi, sama5d36.dtsi
sama5d4.dtsi, sama5d46.dtsi (maybe in the future, who knows...)

3/ all post-3.10 *boards* have the "at91-" prefix, whether they are
populated with sam9 or sama5:
at91-ariag25.dts (since 3.10, using a at91sam9g25)
at91-qil_a9260.dts (since 3.14, using at91sam9260)
at91-sama5d3_xplained.dts (since 3.14, using sama5d36)

The rule for AT91 has never been to prefix the board DT filename with
the name of the SoC or SoC family.

> Care to fix this up in time for 3.16 merge window?

Well, I do not know what to fix as the files were already present in
mainline before this kernel revision and that I am a little bit
reluctant to change file names after they are merged in mainline.

Now, can we keep the current policy described above (somehow weird, I
admit) for future SoCs and boards?

Best regards,
-- 
Nicolas Ferre

  reply	other threads:[~2014-05-20 15:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  9:19 [GIT PULL] at91: DT for 3.16 #2 Nicolas Ferre
2014-05-14  9:19 ` Nicolas Ferre
2014-05-20  5:50 ` Olof Johansson
2014-05-20  5:50   ` Olof Johansson
2014-05-20 15:19   ` Nicolas Ferre [this message]
2014-05-20 15:19     ` Nicolas Ferre
2014-05-20 16:47     ` Olof Johansson
2014-05-20 16:47       ` Olof Johansson
2014-05-21 10:17       ` Nicolas Ferre
2014-05-21 10:17         ` Nicolas Ferre
2014-05-21 21:11         ` Olof Johansson
2014-05-21 21:11           ` Olof Johansson
2014-05-21 21:39           ` Olof Johansson
2014-05-21 21:39             ` Olof Johansson
2014-05-21 21:42           ` Alexandre Belloni
2014-05-21 21:42             ` Alexandre Belloni
2014-05-21 21:51             ` Olof Johansson
2014-05-21 21:51               ` Olof Johansson
2014-05-22  8:48               ` Nicolas Ferre
2014-05-22  8:48                 ` Nicolas Ferre
2014-05-20 17:13   ` Jean-Christophe PLAGNIOL-VILLARD
2014-05-20 17:13     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537B727C.5080404@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.