Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On 04/28/2014 09:25 AM, Tomoki Sekiyama wrote:
> When an array of mount point paths is specified as 'mountpoints' argument
> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file
> systems mounted on specified paths in Linux.

How does the management application learn the set of valid mountpoints
arguments it can pass to this command?  Shouldn't there be a query
counterpart that asks the guest to return the full list of mountpoints
that it can support freezing?  In the case of guests that are
all-or-none, like Windows, the query command would return an empty list
to make it obvious there is no ability to freeze just a subset.

In returning a list of mountpoint names, it might also be nice to
correlate which names map to which devices (it can be a many:many
mapping, thanks to things like RAID setups in the guest).

> This would be useful when the host wants to create partial disk snapshots.
> 
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> ---
>  qga/commands-posix.c |   17 ++++++++++++++++-
>  qga/commands-win32.c |    3 ++-
>  qga/qapi-schema.json |    4 ++++
>  3 files changed, 22 insertions(+), 2 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]