Re: [PATCH] ARM: dts: duovero-parlor: Add HDMI output

[Florian Vaussard <florian.vaussard@epfl.ch>]

On 05/20/2014 08:09 PM, Joachim Eastwood wrote:
> On 20 May 2014 16:25, Florian Vaussard <florian.vaussard@epfl.ch> wrote:
>> Add the necessary DTS nodes to enable the micro-HDMI output on Parlor
>> board.
>>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>>  arch/arm/boot/dts/omap4-duovero-parlor.dts | 42 ++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap4-duovero-parlor.dts b/arch/arm/boot/dts/omap4-duovero-parlor.dts
>> index 96f51d8..3b234b8 100644
>> --- a/arch/arm/boot/dts/omap4-duovero-parlor.dts
>> +++ b/arch/arm/boot/dts/omap4-duovero-parlor.dts
>> @@ -15,6 +15,10 @@
>>         model = "OMAP4430 Gumstix Duovero on Parlor";
>>         compatible = "gumstix,omap4-duovero-parlor", "gumstix,omap4-duovero", "ti,omap4430", "ti,omap4";
>>
>> +       aliases {
>> +               display0 = &hdmi0;
>> +       };
>> +
>>         leds {
>>                 compatible = "gpio-leds";
>>                 led0 {
>> @@ -35,6 +39,19 @@
>>                         gpio-key,wakeup;
>>                 };
>>         };
>> +
>> +       hdmi0: connector@0 {
>> +               compatible = "hdmi-connector";
>> +               label = "hdmi";
>> +
>> +               type = "d";
>> +
>> +               port {
>> +                       hdmi_connector_in: endpoint {
>> +                               remote-endpoint = <&hdmi_out>;
>> +                       };
>> +               };
>> +       };
>>  };
> 
> No, HPD (hotplug) pin?
> 
> I think Parlor has one and the "hdmi-connector" binding now supports
> it. See Tomi's 3.16/fbdev-omap branch.
> 

Looking into the details, the HPD pin of the parlor board is connected
to the OMAP4 HDMI IP. The LINK_CONNECT and LINK_DISCONNECT events are
managed by hdmi_irq_handler() in hdmi4.c to turn on/off the PHY's power.
So there is no need to use the hgp-gpios binding of "hdmi-connector"
IMHO. Correct me if I am wrong, as the public TRM is pretty thin
regarding the OMAP4 HDMI IP.

Regards,
Florian