From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn2Zu-0000Sb-A5 for qemu-devel@nongnu.org; Wed, 21 May 2014 05:12:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn2Zo-0002z3-4v for qemu-devel@nongnu.org; Wed, 21 May 2014 05:12:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52561 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn2Zn-0002y9-Vb for qemu-devel@nongnu.org; Wed, 21 May 2014 05:12:44 -0400 Message-ID: <537C6E0A.4020200@suse.de> Date: Wed, 21 May 2014 11:12:42 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <20140520150510.GH1657@ERROL.INI.CMU.EDU> <537C6696.9000509@suse.de> <20140521090456.GC19109@redhat.com> In-Reply-To: <20140521090456.GC19109@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] e1000: allow command-line selection of card model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: romain@dolbeau.org, qemu-devel@nongnu.org, agraf@suse.de, "Gabriel L. Somlo" , stefanha@redhat.com, pbonzini@redhat.com Am 21.05.2014 11:04, schrieb Michael S. Tsirkin: > On Wed, May 21, 2014 at 10:40:54AM +0200, Andreas F=E4rber wrote: >> Hi, >> >> Am 20.05.2014 17:05, schrieb Gabriel L. Somlo: >>> Allow selection of different card models from the qemu >>> command line, to better accomodate a wider range of guests. >>> >>> Based-on-patch-by: Romain Dolbeau >> >> If that patch carried a Signed-off-by line, you should retain it. >=20 > Actually I think that would be confusing. Romain didn't sign off > on *this* patch, he signed off on a previous one. > A signature by Gabriel indicates Developer's Certificate of Origin 1.1 > which has an option to incorporate other's work - it > does not seem to require signatures by these others. With the same argument you could drop anyone's Sob you get as a maintainer. But the purpose of Sob is to track through whose hands a patch went, not just who last touched it. My point here was that Based-on-patch-by is very unusual. The alternative would be to leave the original From: Romain Dolbeau, his Sob, then a [gsomlo: Dropped this, added that] followed by Sob. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg