From: Chen Gang <gang.chen.5i5j@gmail.com>
To: 管雪涛 <gxt@pku.edu.cn>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>, linux-kernel@vger.kernel.org
Subject: Re: 回复： Re: 回复： [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure
Date: Wed, 21 May 2014 17:31:04 +0800 [thread overview]
Message-ID: <537C7258.2010304@gmail.com> (raw)
In-Reply-To: <1381816856.42144.1400664218906.JavaMail.root@bj-mail03.pku.edu.cn>
On 05/21/2014 05:23 PM, 管雪涛 wrote:
>
> ----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
>>
>> Yeah, I shall send patch v2 for it (within this week). And also thank
>> you for your review the other patches.
>>
>> BTW: I guess, it only leaves 2 kernel related issues for allmodconfig:
>>
>> - one for 'find_first*', 'cpuc_coherent_kern_range' and 'pm_power_off'.
>> I guess, we can export their symbol explicitly to fix this issue.
>
> My suggestion:
> find_first_* could export themselves in lib/find_first.c, so each archs can use it.
> anyway, we can first add them in unicore32, and then make it a generic lib.
> what's the problem with cpuc_coherent_kern_range? in fact, I'll remove it later.
> pm_power_off need be exported.
>
Thank you for your suggestions, and if you have already fixed them
(maybe you have done), please let me know. Or I shall send them within
this month.
The related error for 'cpu_coherent_kern_rage':
ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
>>
>> - the other for additional 'clk_*' which are needed when HAVE_CLK.
>> I guess, just "copy/past" the other platforms' implementation is OK.
>
> Maybe, COMMON_CLK should be selected. I'm not sure.
>
I guess so, if you have already fix it (maybe you have done, I am not
quite familiar with version merging of Linux kernel), please let me
know. Or I shall process (continue think of) it within this month.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2014-05-21 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 0:59 [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure Chen Gang
2014-05-21 8:01 ` 回复： " 管雪涛
2014-05-21 9:10 ` Chen Gang
2014-05-21 9:23 ` 回复： " 管雪涛
2014-05-21 9:31 ` Chen Gang [this message]
2014-05-21 23:59 ` 回复： " 管雪涛
2014-05-22 0:19 ` Chen Gang
2014-05-22 0:31 ` 回复： " 管雪涛
2014-05-22 0:47 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C7258.2010304@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=gxt@pku.edu.cn \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.