From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Wed, 21 May 2014 19:05:45 +0900
Subject: [U-Boot] [PATCH v2 07/12] exynos5: support tps65090 pmic
In-Reply-To: <CAPnjgZ0G5cOkB6aMpZxWM-Padb3zqLw-hbZXNXTniMrwN09u5w@mail.gmail.com>
References: <1396481069-24950-1-git-send-email-sjg@chromium.org>
	<1396481069-24950-8-git-send-email-sjg@chromium.org>
	<537463EC.4080709@samsung.com>
	<CAPnjgZ0G5cOkB6aMpZxWM-Padb3zqLw-hbZXNXTniMrwN09u5w@mail.gmail.com>
Message-ID: <537C7A79.9010901@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 20/05/14 20:47, Simon Glass wrote:
> Hi Minkyu,
> 
> On 15 May 2014 00:51, Minkyu Kang <mk7.kang@samsung.com> wrote:
>> On 03/04/14 08:24, Simon Glass wrote:
>>> From: Aaron Durbin <adurbin@chromium.org>
>>>
>>> The TSP65090 is a PMIC on some exynos5 boards. The init function is
>>> called for the TPS65090 pmic. If that device is not a part of the device
>>> tree (returns -ENODEV) then continue. Otherwise return a failure.
>>>
>>> Signed-off-by: Aaron Durbin <adurbin@chromium.org>
>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>> ---
>>>
>>> Changes in v2:
>>> - Move code to exynos5-dt.c
>>> - Fix comment style
>>> - Add #ifdef around tps65090 code
>>>
>>>  board/samsung/smdk5250/exynos5-dt.c | 13 +++++++++++++
>>>  1 file changed, 13 insertions(+)
>>>
>>> diff --git a/board/samsung/smdk5250/exynos5-dt.c b/board/samsung/smdk5250/exynos5-dt.c
>>> index 1a64b9b..2c1cf8a 100644
>>> --- a/board/samsung/smdk5250/exynos5-dt.c
>>> +++ b/board/samsung/smdk5250/exynos5-dt.c
>>> @@ -20,6 +20,7 @@
>>>  #include <asm/arch/sromc.h>
>>>  #include <power/pmic.h>
>>>  #include <power/max77686_pmic.h>
>>> +#include <power/tps65090_pmic.h>
>>>  #include <tmu.h>
>>>
>>>  DECLARE_GLOBAL_DATA_PTR;
>>> @@ -164,7 +165,19 @@ int exynos_power_init(void)
>>>
>>>  #ifdef CONFIG_POWER_MAX77686
>>>       ret = max77686_init();
>>> +     if (ret)
>>> +             return ret;
>>>  #endif
>>> +#ifdef CONFIG_POWER_TPS65090
>>> +     /*
>>> +      * The TPS65090 may not be in the device tree. If so, it is not
>>> +      * an error.
>>
>> Then, how we can initialise the tps65090?
> 
> It is initialised if a suitable node is found in the device tree. If
> the device tree does not have it, then the hardware is assumed to not
> have this chip.

then I think, it's an error.
Why you said, it is not an error?

> 
>>
>>> +      */
>>> +     ret = tps65090_init();
>>> +     if (ret == 0 || ret == -ENODEV)
>>> +             return 0;
>>> +#endif
>>> +
>>>       return ret;
>>>  }
>>>  #endif       /* CONFIG_POWER */
>>>
>>
>> Thanks,
>> Minkyu Kang.
> 
> Regards,
> Simon
> 

Thanks,
Minkyu Kang.