All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 2/5] hvm: add HVM_PARAM_VM_GENERATION_ID_ADDR
Date: Wed, 21 May 2014 14:45:23 +0100	[thread overview]
Message-ID: <537CADF3.7060401@citrix.com> (raw)
In-Reply-To: <1400678467-23559-3-git-send-email-david.vrabel@citrix.com>

On 21/05/14 14:21, David Vrabel wrote:
> HVM_PARAM_VM_GENERATION_ID_ADDR is the guest physical address of the
> VM Generation ID.  This parameter will be written by hvmloader and read
> by the toolstack when updating the gen. ID (e.g., after restoring from a
> snapshot).
>
> A HVM parameter is easier for the save/restore code to work with (than
> a XenStore key).
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> ---
>  xen/include/public/hvm/params.h |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
> index 517a184..c972f9e 100644
> --- a/xen/include/public/hvm/params.h
> +++ b/xen/include/public/hvm/params.h
> @@ -145,6 +145,9 @@
>  /* SHUTDOWN_* action in case of a triple fault */
>  #define HVM_PARAM_TRIPLE_FAULT_REASON 31
>  
> -#define HVM_NR_PARAMS          32
> +/* Location of the VM Generation ID in guest address space. */

Might be more clear to say "guest physical address space" ?

> +#define HVM_PARAM_VM_GENERATION_ID_ADDR 32
> +
> +#define HVM_NR_PARAMS          33
>  
>  #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */

  reply	other threads:[~2014-05-21 13:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 13:21 [PATCHv1 0/5] tools: rework VM Generation ID David Vrabel
2014-05-21 13:21 ` [PATCH 1/5] docs: update docs for the ~/platform/generation-id key David Vrabel
2014-05-21 13:21 ` [PATCH 2/5] hvm: add HVM_PARAM_VM_GENERATION_ID_ADDR David Vrabel
2014-05-21 13:45   ` Andrew Cooper [this message]
2014-05-21 13:21 ` [PATCH 3/5] tools/hvmloader: add helper functions to get/set HVM params David Vrabel
2014-05-21 13:21 ` [PATCH 4/5] libxc, libxl, hvmloader: strip out outdated VM generation ID implementation David Vrabel
2014-05-21 13:21 ` [PATCH 5/5] libxl: add libxl_vm_generation_id_set() David Vrabel
2014-05-21 16:10   ` Ian Campbell
2014-05-21 16:27     ` Paul Durrant
2014-05-21 16:07 ` [PATCHv1 0/5] tools: rework VM Generation ID Ian Campbell
2014-05-22 10:44   ` David Vrabel
2014-05-21 16:13 ` Ian Jackson
2014-05-21 16:18 ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537CADF3.7060401@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.