From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev
Date: Wed, 21 May 2014 10:18:53 -0600 [thread overview]
Message-ID: <537CD1ED.6060309@wwwdotorg.org> (raw)
In-Reply-To: <537C3C42.4080801@samsung.com>
On 05/20/2014 11:40 PM, Jaehoon Chung wrote:
> Hi, Stephen.
>
> i didn't apply your patch. Which repository do you use?
It's based on u-boot.git master branch. The latest u-boot-mmc.git master
branch is already included in that branch, and it looks like some
changes have been applied to cmd_mmc.c in u-boot/master that aren't in
u-boot-mmc/master.
> Well, if you want to check, can be used "if (mmc_init(mmc))".
>
> And i'm not sure whether this code is really need or not.
Why not? This code is required to solve the problem described in the
commit description:
> On 05/21/2014 01:57 AM, Stephen Warren wrote:
>> From: Bryan Wu <cooloney@gmail.com>
>>
>> mmc dev ${devnum} will return 0 as success even if there is no card
>> inserted. Booting script like tegra-common-post.h will call mmc dev
>> ${devnum} to check the mmc device status, it always return 0 even if
>> mmc_init() fails.
next prev parent reply other threads:[~2014-05-21 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 16:57 [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev Stephen Warren
2014-05-21 5:40 ` Jaehoon Chung
2014-05-21 16:18 ` Stephen Warren [this message]
2014-05-22 1:41 ` Jaehoon Chung
2014-05-22 16:11 ` Stephen Warren
2014-05-23 18:59 ` Stephen Warren
2014-06-12 11:13 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CD1ED.6060309@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.