* [meta-oe][PATCH] faac: fix S!=B failure
@ 2014-05-20 12:56 Matthieu Crapet
2014-05-20 16:17 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Matthieu Crapet @ 2014-05-20 12:56 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
---
meta-multimedia/recipes-multimedia/faac/faac_1.28.bb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
index c7dcdb9..d96c1a4 100644
--- a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
+++ b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
@@ -4,15 +4,15 @@ LICENSE = "LGPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
file://libfaac/coder.h;beginline=5;endline=17;md5=fa1fd6a5fa8cdc877d63a12530d273e0"
-inherit autotools
+inherit autotools-brokensep
-SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BPN}-${PV}.tar.gz \
+SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BP}.tar.gz \
file://build-fix.patch"
SRC_URI[md5sum] = "80763728d392c7d789cde25614c878f6"
SRC_URI[sha256sum] = "c5141199f4cfb17d749c36ba8cfe4b25f838da67c22f0fec40228b6b9c3d19df"
-PACKAGES =+ "lib${PN} lib${PN}-dev"
+PACKAGES =+ "lib${BPN} lib${BPN}-dev"
FILES_${PN} = " ${bindir}/faac "
FILES_lib${PN} = " ${libdir}/libfaac.so.*"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [meta-oe][PATCH] faac: fix S!=B failure
2014-05-20 12:56 [meta-oe][PATCH] faac: fix S!=B failure Matthieu Crapet
@ 2014-05-20 16:17 ` Khem Raj
2014-05-21 7:30 ` [meta-oe][PATCH v2] " Matthieu Crapet
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2014-05-20 16:17 UTC (permalink / raw)
To: openembeded-devel
On Tue, May 20, 2014 at 5:56 AM, Matthieu Crapet
<Matthieu.Crapet@ingenico.com> wrote:
> -SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BPN}-${PV}.tar.gz \
> +SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BP}.tar.gz \
> file://build-fix.patch"
>
> SRC_URI[md5sum] = "80763728d392c7d789cde25614c878f6"
> SRC_URI[sha256sum] = "c5141199f4cfb17d749c36ba8cfe4b25f838da67c22f0fec40228b6b9c3d19df"
>
> -PACKAGES =+ "lib${PN} lib${PN}-dev"
> +PACKAGES =+ "lib${BPN} lib${BPN}-dev"
these changes should be mentioned in commit message too.
^ permalink raw reply [flat|nested] 5+ messages in thread* [meta-oe][PATCH v2] faac: fix S!=B failure
2014-05-20 16:17 ` Khem Raj
@ 2014-05-21 7:30 ` Matthieu Crapet
2014-05-21 16:36 ` Andreas Oberritter
0 siblings, 1 reply; 5+ messages in thread
From: Matthieu Crapet @ 2014-05-21 7:30 UTC (permalink / raw)
To: openembedded-devel
Also use ${BP} and ${BPN}.
Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
---
meta-multimedia/recipes-multimedia/faac/faac_1.28.bb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
index c7dcdb9..d96c1a4 100644
--- a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
+++ b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
@@ -4,15 +4,15 @@ LICENSE = "LGPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
file://libfaac/coder.h;beginline=5;endline=17;md5=fa1fd6a5fa8cdc877d63a12530d273e0"
-inherit autotools
+inherit autotools-brokensep
-SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BPN}-${PV}.tar.gz \
+SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BP}.tar.gz \
file://build-fix.patch"
SRC_URI[md5sum] = "80763728d392c7d789cde25614c878f6"
SRC_URI[sha256sum] = "c5141199f4cfb17d749c36ba8cfe4b25f838da67c22f0fec40228b6b9c3d19df"
-PACKAGES =+ "lib${PN} lib${PN}-dev"
+PACKAGES =+ "lib${BPN} lib${BPN}-dev"
FILES_${PN} = " ${bindir}/faac "
FILES_lib${PN} = " ${libdir}/libfaac.so.*"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [meta-oe][PATCH v2] faac: fix S!=B failure
2014-05-21 7:30 ` [meta-oe][PATCH v2] " Matthieu Crapet
@ 2014-05-21 16:36 ` Andreas Oberritter
2014-05-22 8:16 ` Paul Eggleton
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Oberritter @ 2014-05-21 16:36 UTC (permalink / raw)
To: openembedded-devel
Hello Matthieu,
On 21.05.2014 09:30, Matthieu Crapet wrote:
> Also use ${BP} and ${BPN}.
What problem does this solve?
>
> Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
> ---
> meta-multimedia/recipes-multimedia/faac/faac_1.28.bb | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
> index c7dcdb9..d96c1a4 100644
> --- a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
> +++ b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
> @@ -4,15 +4,15 @@ LICENSE = "LGPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
> file://libfaac/coder.h;beginline=5;endline=17;md5=fa1fd6a5fa8cdc877d63a12530d273e0"
>
> -inherit autotools
> +inherit autotools-brokensep
>
> -SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BPN}-${PV}.tar.gz \
> +SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BP}.tar.gz \
> file://build-fix.patch"
>
> SRC_URI[md5sum] = "80763728d392c7d789cde25614c878f6"
> SRC_URI[sha256sum] = "c5141199f4cfb17d749c36ba8cfe4b25f838da67c22f0fec40228b6b9c3d19df"
>
> -PACKAGES =+ "lib${PN} lib${PN}-dev"
> +PACKAGES =+ "lib${BPN} lib${BPN}-dev"
>
> FILES_${PN} = " ${bindir}/faac "
> FILES_lib${PN} = " ${libdir}/libfaac.so.*"
^
This differs from PACKAGES now.
Regards,
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [meta-oe][PATCH v2] faac: fix S!=B failure
2014-05-21 16:36 ` Andreas Oberritter
@ 2014-05-22 8:16 ` Paul Eggleton
0 siblings, 0 replies; 5+ messages in thread
From: Paul Eggleton @ 2014-05-22 8:16 UTC (permalink / raw)
To: Matthieu Crapet; +Cc: openembedded-devel
On Wednesday 21 May 2014 18:36:29 Andreas Oberritter wrote:
> Hello Matthieu,
>
> On 21.05.2014 09:30, Matthieu Crapet wrote:
> > Also use ${BP} and ${BPN}.
>
> What problem does this solve?
>
> > Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
> > ---
> >
> > meta-multimedia/recipes-multimedia/faac/faac_1.28.bb | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
> > b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb index
> > c7dcdb9..d96c1a4 100644
> > --- a/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
> > +++ b/meta-multimedia/recipes-multimedia/faac/faac_1.28.bb
> > @@ -4,15 +4,15 @@ LICENSE = "LGPLv2+"
> >
> > LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
> >
> > file://libfaac/coder.h;beginline=5;endline=17;md5=fa1
> > fd6a5fa8cdc877d63a12530d273e0">
> > -inherit autotools
> > +inherit autotools-brokensep
> >
> > -SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BPN}-${PV}.tar.gz \
> > +SRC_URI = "${SOURCEFORGE_MIRROR}/faac/${BP}.tar.gz \
> >
> > file://build-fix.patch"
> >
> > SRC_URI[md5sum] = "80763728d392c7d789cde25614c878f6"
> > SRC_URI[sha256sum] =
> > "c5141199f4cfb17d749c36ba8cfe4b25f838da67c22f0fec40228b6b9c3d19df">
> > -PACKAGES =+ "lib${PN} lib${PN}-dev"
> > +PACKAGES =+ "lib${BPN} lib${BPN}-dev"
> >
> > FILES_${PN} = " ${bindir}/faac "
> > FILES_lib${PN} = " ${libdir}/libfaac.so.*"
>
> ^
> This differs from PACKAGES now.
Also, BPN should not generally be used in PACKAGES, or nativesdk packages will
clash with target ones.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-22 8:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-20 12:56 [meta-oe][PATCH] faac: fix S!=B failure Matthieu Crapet
2014-05-20 16:17 ` Khem Raj
2014-05-21 7:30 ` [meta-oe][PATCH v2] " Matthieu Crapet
2014-05-21 16:36 ` Andreas Oberritter
2014-05-22 8:16 ` Paul Eggleton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.