All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	kernel-janitors@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [patch] [XFS] indent an if statement
Date: Wed, 21 May 2014 16:50:53 +0000	[thread overview]
Message-ID: <537CD96D.2090901@bfs.de> (raw)
In-Reply-To: <20140521143550.GC15585@mwanda>



Am 21.05.2014 16:35, schrieb Dan Carpenter:
> On Wed, May 21, 2014 at 07:29:09AM -0700, Christoph Hellwig wrote:
>> On Wed, May 21, 2014 at 03:27:46PM +0300, Dan Carpenter wrote:
>>> The "n += 32;" goes with the if statement on the line before so it
>>> should be indented.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> diff --git a/fs/xfs/xfs_bit.h b/fs/xfs/xfs_bit.h
>>> index f1e3c90..f685942 100644
>>> --- a/fs/xfs/xfs_bit.h
>>> +++ b/fs/xfs/xfs_bit.h
>>> @@ -67,7 +67,7 @@ static inline int xfs_lowbit64(__uint64_t v)
>>>  	} else {	/* upper bits */
>>>  		w = (__uint32_t)(v >> 32);
>>>  		if (w && (n = ffs(w)))
>>> -		n += 32;
>>> +			n += 32;
>>
>> If we want to clean up this stuff let's do it properly:
>>
>> 		if (w) {
>> 			n = ffs(w);
>> 			if (n)
>> 				n += 32;
>> 		}
>>
> 


This looks like a ffsll() maybe there are other implemantions and we can
make a generic version (acualy i found only a ffsll() in nouvou, NTL).

just my 2 cents,

re,
 wh


> Sure.  I will resend.
> 
> regards,
> dan carpenter
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	kernel-janitors@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [patch] [XFS] indent an if statement
Date: Wed, 21 May 2014 18:50:53 +0200	[thread overview]
Message-ID: <537CD96D.2090901@bfs.de> (raw)
In-Reply-To: <20140521143550.GC15585@mwanda>



Am 21.05.2014 16:35, schrieb Dan Carpenter:
> On Wed, May 21, 2014 at 07:29:09AM -0700, Christoph Hellwig wrote:
>> On Wed, May 21, 2014 at 03:27:46PM +0300, Dan Carpenter wrote:
>>> The "n += 32;" goes with the if statement on the line before so it
>>> should be indented.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> diff --git a/fs/xfs/xfs_bit.h b/fs/xfs/xfs_bit.h
>>> index f1e3c90..f685942 100644
>>> --- a/fs/xfs/xfs_bit.h
>>> +++ b/fs/xfs/xfs_bit.h
>>> @@ -67,7 +67,7 @@ static inline int xfs_lowbit64(__uint64_t v)
>>>  	} else {	/* upper bits */
>>>  		w = (__uint32_t)(v >> 32);
>>>  		if (w && (n = ffs(w)))
>>> -		n += 32;
>>> +			n += 32;
>>
>> If we want to clean up this stuff let's do it properly:
>>
>> 		if (w) {
>> 			n = ffs(w);
>> 			if (n)
>> 				n += 32;
>> 		}
>>
> 


This looks like a ffsll() maybe there are other implemantions and we can
make a generic version (acualy i found only a ffsll() in nouvou, NTL).

just my 2 cents,

re,
 wh


> Sure.  I will resend.
> 
> regards,
> dan carpenter
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-05-21 16:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 12:27 [patch] [XFS] indent an if statement Dan Carpenter
2014-05-21 12:27 ` Dan Carpenter
2014-05-21 12:44 ` Eric Sandeen
2014-05-21 12:44   ` Eric Sandeen
2014-05-21 14:29 ` Christoph Hellwig
2014-05-21 14:29   ` Christoph Hellwig
2014-05-21 14:35   ` Dan Carpenter
2014-05-21 14:35     ` Dan Carpenter
2014-05-21 16:50     ` walter harms [this message]
2014-05-21 16:50       ` walter harms
2014-05-22 10:01       ` Christoph Hellwig
2014-05-22 10:01         ` Christoph Hellwig
2014-05-22 13:31         ` Mark Tinguely
2014-05-22 13:31           ` Mark Tinguely
2014-05-22 14:04   ` [patch v2] [XFS] small cleanup in xfs_lowbit64() Dan Carpenter
2014-05-22 14:04     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537CD96D.2090901@bfs.de \
    --to=wharms@bfs.de \
    --cc=dan.carpenter@oracle.com \
    --cc=hch@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.