From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnDVZ-00031d-86 for qemu-devel@nongnu.org; Wed, 21 May 2014 16:53:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnDVT-0006iE-QU for qemu-devel@nongnu.org; Wed, 21 May 2014 16:53:05 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=59974 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnDVT-0006i3-Jo for qemu-devel@nongnu.org; Wed, 21 May 2014 16:52:59 -0400 Message-ID: <537D1224.8080504@weilnetz.de> Date: Wed, 21 May 2014 22:52:52 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1400661841-16031-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1400661841-16031-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/25] qemu gtk ui overhaul List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Am 21.05.2014 10:43, schrieb Gerd Hoffmann: > Hi, > > I'm trying to put the qemu gtk ui into shape. Fixing a bunch of > issues we have, and also make it ready for multihead support. > > Git tree is here: > git://git.kraxel.org/qemu rebase/ui-gtk-next > > please review, > Gerd > Hi Gerd, I did some tests with Linux und Windows versions of QEMU based on your code. Both compile and work. The "Detach Tab" feature is something which I have missed since a long time (also for SDL), great to see it implemented now. Here are some first results from a short test. I noticed that some issues with the old code still exist: when "Show tabs" is enabled and disabled again, QEMU adds some black scan lines at the top of the VGA screen. This can be easily reproduced. Another small problem is "Zoom To Fit" which sometimes changes the display even if it was optimal before (more difficult to reproduce). "Fullscreen" shows some new issues with your code (tested on a 1024x600 Linux netbook). With Alt+Ctrl+F in non detached compatmonitor0 I get a display which continuously switches from fullscreen to non fullscreen. In detached mode, a fullscreen VGA display shows some white scan lines at the top. It would be nice to have scroll bars when necessary. On my small display it is no longer possible to see the whole compatmonitor0 contents (it's larger than my display, zooming or resizing the window does not work and there are no scroll bars). Regards Stefan