From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: gadget: f_rndis: fix an error code on allocation failure
Date: Thu, 22 May 2014 05:16:13 +0000 [thread overview]
Message-ID: <537D881D.6050408@samsung.com> (raw)
In-Reply-To: <20140521122655.GC23396@mwanda>
W dniu 21.05.2014 14:26, Dan Carpenter pisze:
> This should be return -ENOMEM. The current code returns successs.
>
> Fixes: de7a8d2d534f ('usb: gadget: f_rndis: OS descriptors support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> diff --git a/drivers/usb/gadget/f_rndis.c b/drivers/usb/gadget/f_rndis.c
> index eed3ad8..31274f7 100644
> --- a/drivers/usb/gadget/f_rndis.c
> +++ b/drivers/usb/gadget/f_rndis.c
> @@ -687,7 +687,7 @@ rndis_bind(struct usb_configuration *c, struct usb_function *f)
> f->os_desc_table = kzalloc(sizeof(*f->os_desc_table),
> GFP_KERNEL);
> if (!f->os_desc_table)
> - return PTR_ERR(f->os_desc_table);
> + return -ENOMEM;
> f->os_desc_n = 1;
> f->os_desc_table[0].os_desc = &rndis_opts->rndis_os_desc;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-05-22 5:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:26 [patch] usb: gadget: f_rndis: fix an error code on allocation failure Dan Carpenter
2014-05-22 5:16 ` Andrzej Pietrasiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537D881D.6050408@samsung.com \
--to=andrzej.p@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.