All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi
Date: Thu, 22 May 2014 09:03:47 +0200	[thread overview]
Message-ID: <537DA153.2080501@redhat.com> (raw)
In-Reply-To: <1400740589-3655-2-git-send-email-famz@redhat.com>

Il 22/05/2014 08:36, Fam Zheng ha scritto:
> -
> -    if (!req->dev->blk.scsi) {
> -        status = VIRTIO_BLK_S_UNSUPP;
> -        goto fail;
> -    }

Where did you move this condition?

Also, the scsi field of VirtIOBlockReq is now unused.

Paolo

  reply	other threads:[~2014-05-22  7:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22  6:36 [Qemu-devel] [PATCH 0/2] dataplane: Enable "scsi=on" Fam Zheng
2014-05-22  6:36 ` [Qemu-devel] [PATCH 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi Fam Zheng
2014-05-22  7:03   ` Paolo Bonzini [this message]
2014-05-22  7:11     ` Fam Zheng
2014-05-22  6:36 ` [Qemu-devel] [PATCH 2/2] dataplane: Support VIRTIO_BLK_T_SCSI_CMD Fam Zheng
2014-05-22  7:04   ` Paolo Bonzini
2014-05-22  7:06 ` [Qemu-devel] [PATCH 0/2] dataplane: Enable "scsi=on" Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537DA153.2080501@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.