From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>,
tim@xen.org, stefano.stabellini@eu.citrix.com,
ian.jackson@eu.citrix.com
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH v5 7/9] tools: arm: prepare guest FDT building for multiple RAM banks
Date: Thu, 22 May 2014 11:22:46 +0100 [thread overview]
Message-ID: <537DCFF6.3050805@linaro.org> (raw)
In-Reply-To: <1400752004-9731-7-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 22/05/14 10:46, Ian Campbell wrote:
> - assert(rambank_size[0] != 0);
> + assert(dom->rambank_size[0] != 0);
> assert(ramsize == 0); /* Too much RAM is rejected above */
>
> dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) * p2m_size);
> @@ -354,11 +353,10 @@ int arch_setup_meminit(struct xc_dom_image *dom)
> dom->p2m_host[pfn] = INVALID_MFN;
>
> /* setup initial p2m and allocate guest memory */
> - for ( i = 0; rambank_size[i] && i < GUEST_RAM_BANKS; i++ )
> - {
> + for ( i = 0; dom->rambank_size[i] && i < GUEST_RAM_BANKS; i++ ) {
We are in libxc, so the previous coding style was valid, i.e:
for ( ... )
{
}
Other than this minor change:
Acked-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-05-22 10:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 9:39 [PATCH v5 0/9] xen: arm: support up to (almost) 1TB of guest RAM Ian Campbell
2014-05-22 9:46 ` [PATCH v5 1/9] tools: libxl: use uint64_t not unsigned long long for addresses Ian Campbell
2014-05-22 9:46 ` [PATCH v5 2/9] tools: arm: report an error if the guest RAM is too large Ian Campbell
2014-07-02 15:06 ` Ian Jackson
2014-05-22 9:46 ` [PATCH v5 3/9] tools: arm: move magic pfns out of guest RAM region Ian Campbell
2014-05-22 9:46 ` [PATCH v5 4/9] tools: arm: rearrange guest physical address space to increase max RAM Ian Campbell
2014-05-22 9:46 ` [PATCH v5 5/9] tools: arm: refactor code to setup guest p2m and fill it with RAM Ian Campbell
2014-05-22 16:50 ` Ian Jackson
2014-05-22 9:46 ` [PATCH v5 6/9] tools: arm: prepare domain builder for multiple banks of guest RAM Ian Campbell
2014-05-22 10:18 ` Julien Grall
2014-05-22 16:52 ` Ian Jackson
2014-05-22 9:46 ` [PATCH v5 7/9] tools: arm: prepare guest FDT building for multiple RAM banks Ian Campbell
2014-05-22 10:22 ` Julien Grall [this message]
2014-05-22 16:55 ` Ian Jackson
2014-05-23 8:43 ` Ian Campbell
2014-05-22 9:46 ` [PATCH v5 8/9] tools: arm: support up to (almost) 1TB of guest RAM Ian Campbell
2014-05-22 10:25 ` Julien Grall
2014-05-22 16:55 ` Ian Jackson
2014-05-22 9:46 ` [PATCH v5 9/9] tools: arm: increase size of region set aside for guest grant table Ian Campbell
2014-06-02 14:42 ` [PATCH v5 0/9] xen: arm: support up to (almost) 1TB of guest RAM Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537DCFF6.3050805@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.