All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Wiegand <sebastian.wiegand@gersys.de>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [CONSOLIDATED PULL 00/16] CVE Patches and updates
Date: Thu, 22 May 2014 12:34:10 +0200	[thread overview]
Message-ID: <537DD2A2.6000001@gersys.de> (raw)
In-Reply-To: <CAJTo0LY6+fwJAnvgq-BUAp=kArxosj9J4wYRsvh42QvawfScpA@mail.gmail.com>


On Thursday, 22.05.2014 12:10 +0200, Burton, Ross 
<ross.burton@intel.com> wrote:
> On 22 May 2014 10:58, Sebastian Wiegand <sebastian.wiegand@gersys.de> wrote:
>> Reworked and fixed the error message, too.
> Can you send this patch using e.g. git format-patch so the commit
> message is correct, and add a signed-off-by.
>
> Ross
From: Sebastian Wiegand <sebastian.wiegand@gersys.de>
Date: Thu, 22 May 2014 12:24:16 +0200
Subject: [PATCH] distro_features_check.bbclass: fix searching whole list

Search whole list of REQUIRED_DISTRO_FEATURES.
Print only the missing/conflicting feature on error.

Signed-off-by: Sebastian Wiegand <sebastian.wiegand@gersys.de>
---
  meta/classes/distro_features_check.bbclass |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/classes/distro_features_check.bbclass 
b/meta/classes/distro_features_check.bbclass
index 8a0ecb7..1f1d6fb 100644
--- a/meta/classes/distro_features_check.bbclass
+++ b/meta/classes/distro_features_check.bbclass
@@ -14,9 +14,9 @@ python () {
          distro_features = (d.getVar('DISTRO_FEATURES', True) or 
"").split()
          for f in required_distro_features:
              if f in distro_features:
-                break
+                continue
              else:
-                raise bb.parse.SkipPackage("missing required distro 
feature %s (not in DISTRO_FEATURES)" % required_distro_features)
+                raise bb.parse.SkipPackage("missing required distro 
feature '%s' (not in DISTRO_FEATURES)" % f)

      conflict_distro_features = d.getVar('CONFLICT_DISTRO_FEATURES', True)
      if conflict_distro_features:
@@ -24,5 +24,5 @@ python () {
          distro_features = (d.getVar('DISTRO_FEATURES', True) or 
"").split()
          for f in conflict_distro_features:
              if f in distro_features:
-                raise bb.parse.SkipPackage("conflicting distro feature 
%s (in DISTRO_FEATURES)" % conflict_distro_features)
+                raise bb.parse.SkipPackage("conflicting distro feature 
'%s' (in DISTRO_FEATURES)" % f)
  }
-- 
1.7.9.5




  reply	other threads:[~2014-05-22 10:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22  6:57 [CONSOLIDATED PULL 00/16] CVE Patches and updates Jacob Kroon
2014-05-22  9:58 ` Sebastian Wiegand
2014-05-22 10:10   ` Burton, Ross
2014-05-22 10:34     ` Sebastian Wiegand [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-21 18:01 Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537DD2A2.6000001@gersys.de \
    --to=sebastian.wiegand@gersys.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.