From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCHv1 0/5] tools: rework VM Generation ID
Date: Thu, 22 May 2014 11:44:28 +0100
Message-ID: <537DD50C.5070206@citrix.com>
References: <1400678467-23559-1-git-send-email-david.vrabel@citrix.com>
	<1400688425.7272.34.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1WnQUC-0002L8-SS
	for xen-devel@lists.xenproject.org; Thu, 22 May 2014 10:44:33 +0000
In-Reply-To: <1400688425.7272.34.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 21/05/14 17:07, Ian Campbell wrote:
> On Wed, 2014-05-21 at 14:21 +0100, David Vrabel wrote:
>> This series reworks the VM Generation ID to a) conform to the
>> published spec from Microsoft; b) simplify the save/restore code; and
>> c) extend the libxl API to allow toolstacks to use this feature.
>>
>> The VM Generation ID must be regenerated with a new random ID after
>> certain VM operations. For xl, a new ID is required when restoring
>> from a saved image (but not after a migration, reboot, pause/unpause).
> 
> Does reboot include shutdown and recreate? i.e. if I do
>  xl shutdown domain
>  xl create domain.cfg
> 
> what should happen?

It may use the same ID.

> If we have to preserve then that is going to be problematic for xl,
> since:
>  xl create domain.cfg

ID = A

>  xl save domain saved
>  xl restore saved # now the genid has changed

ID = B

>  xl shutdown domain
>  xl cr domain.cfg

ID = B

> has nowhere to store the new genid, even if domain.cfg were to contain
> the original one.

Yes.

I think I might just get xl to generate a new ID on every domain create
and restore/migrate.  This will give the correct behaviour where it
matter, even if it is sub-optimal.

I doubt anyone is running a Windows 2012 domain controller with xl anyway.

David