From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQkQ-00066A-7m for qemu-devel@nongnu.org; Thu, 22 May 2014 07:01:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnQkH-0007c7-8W for qemu-devel@nongnu.org; Thu, 22 May 2014 07:01:18 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:57778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQkH-0007bw-26 for qemu-devel@nongnu.org; Thu, 22 May 2014 07:01:09 -0400 Received: by mail-pa0-f47.google.com with SMTP id lf10so2381545pab.6 for ; Thu, 22 May 2014 04:01:08 -0700 (PDT) Message-ID: <537DD8EF.1090600@ozlabs.ru> Date: Thu, 22 May 2014 21:01:03 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <537CB795.7050702@suse.de> <1400685701-8403-1-git-send-email-aik@ozlabs.ru> <537DD5A6.6010609@suse.de> In-Reply-To: <537DD5A6.6010609@suse.de> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] spapr: Enable dynamic change of the supported hypercalls list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 05/22/2014 08:47 PM, Alexander Graf wrote: > > On 21.05.14 17:21, Alexey Kardashevskiy wrote: >> At the moment the "ibm,hypertas-functions" list is fixed. However some >> calls should be listed there if they are supported by QEMU or the host >> kernel. >> >> This enables hyperrtas_prop to grow on stack by adding >> a SPAPR_HYPERRTAS_ADD macro. "qemu,hypertas-functions" is converted as well. >> >> The first user of this is going to be a "multi-tce" property. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> Changes: >> v2: >> * replaced alloca() with GString >> --- >> hw/ppc/spapr.c | 30 +++++++++++++++++++++++------- >> 1 file changed, 23 insertions(+), 7 deletions(-) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 0a61246..3b28211 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -293,6 +293,10 @@ static size_t create_page_sizes_prop(CPUPPCState >> *env, uint32_t *prop, >> } \ >> } while (0) >> +static inline void add_str(GString *s, const gchar *s1) > > Please remove the "inline" :). Otherwise this looks a lot nicer than before :) Good :) What now? Have you finished with this set and I can repost it? -- Alexey