From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Frederic Konrad <fred.konrad@greensocs.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()
Date: Thu, 22 May 2014 13:16:47 +0200 [thread overview]
Message-ID: <537DDC9F.4030403@redhat.com> (raw)
In-Reply-To: <CAJSP0QUMER2Fe5AGdVNmEKv-kxzBaDSfa0NNfczvZOVizYSrJQ@mail.gmail.com>
Il 22/05/2014 12:23, Stefan Hajnoczi ha scritto:
> I had an intermediate version of this patch with a flag so you could
> tell object_property_add_alias() whether or not to ref the target
> object. But in the end it seems like overengineering since the
> refcount case is rare or non-existent. The refcount is a convenience
> feature just for the case where you want to alias to a random object
> that you don't otherwise hold a refcount on (I couldn't think of an
> example).
>
> Do you see what I mean?
Yes, and it makes sense. Perhaps add a comment for v2.
Paolo
next prev parent reply other threads:[~2014-05-22 11:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 20:22 [Qemu-devel] [PATCH 0/7] virtio-blk: use alias properties in transport devices Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias() Stefan Hajnoczi
2014-05-21 22:05 ` Paolo Bonzini
2014-05-22 10:23 ` Stefan Hajnoczi
2014-05-22 11:16 ` Paolo Bonzini [this message]
2014-05-22 14:02 ` Peter Crosthwaite
2014-05-22 14:05 ` Andreas Färber
2014-05-22 14:38 ` Stefan Hajnoczi
2014-05-23 6:23 ` Peter Crosthwaite
2014-05-22 14:05 ` Igor Mammedov
2014-05-22 14:39 ` Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 2/7] virtio-blk: avoid qdev property definition duplication Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 3/7] virtio-blk: move x-data-plane qdev property to virtio-blk.h Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties Stefan Hajnoczi
2014-05-21 22:04 ` Paolo Bonzini
2014-05-22 10:17 ` Stefan Hajnoczi
2014-05-22 11:15 ` Paolo Bonzini
2014-05-22 10:18 ` Andreas Färber
2014-05-22 10:24 ` Stefan Hajnoczi
2014-05-22 10:32 ` Andreas Färber
2014-05-22 14:08 ` Peter Crosthwaite
2014-05-21 20:22 ` [Qemu-devel] [PATCH 5/7] virtio-blk: drop virtio_blk_set_conf() Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 6/7] virtio: fix virtio-blk child refcount in transports Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 7/7] virtio-blk: move qdev properties into virtio-blk.c Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537DDC9F.4030403@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=fred.konrad@greensocs.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.