From: Amir Vadai <amirv@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <yevgenyp@mellanox.com>,
<ogerlitz@mellanox.com>, <clsoto@linux.vnet.ibm.com>
Subject: Re: [PATCH net-next 1/2] net/mlx4_core: Deprecate use_prio module parameter
Date: Thu, 22 May 2014 15:59:28 +0300 [thread overview]
Message-ID: <537DF4B0.3050006@mellanox.com> (raw)
In-Reply-To: <20140521.154952.422112298525039373.davem@davemloft.net>
On 5/21/2014 10:49 PM, David Miller wrote:
> From: Amir Vadai <amirv@mellanox.com>
> Date: Mon, 19 May 2014 11:37:41 +0300
>
>> It was used for steering by user priority for A0 steering. A0 mode is
>> not supported anymore. Printing a message and ignoring the parameter.
>>
>> CC: Carol Soto <clsoto@linux.vnet.ibm.com>
>> Signed-off-by: Amir Vadai <amirv@mellanox.com>
>
> So you completely took away a feature that was publicly exposed and
> available to the user?
>
> Sorry this is still not acceptable, you have to bring back A0
> steering, what if someone was using it?
>
> I sense you really don't care, and that I find really disturbing.
>
My description wasn't accurate. I resubmitted the patch set with a
better explanation about the purpose of this module param, and why we
don't expect that anything will break for anyone because we deprecated it.
Amir
next prev parent reply other threads:[~2014-05-22 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 8:37 [PATCH net-next 0/2] net/mlx4_core: Deprecate module parameter use_prio Amir Vadai
2014-05-19 8:37 ` [PATCH net-next 1/2] net/mlx4_core: Deprecate use_prio module parameter Amir Vadai
2014-05-21 19:49 ` David Miller
2014-05-22 12:59 ` Amir Vadai [this message]
2014-05-26 19:22 ` Ben Hutchings
2014-05-27 8:08 ` Amir Vadai
2014-05-19 8:37 ` [PATCH net-next 2/2] net/mlx4_core: Replace pr_warning() with pr_warn() Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537DF4B0.3050006@mellanox.com \
--to=amirv@mellanox.com \
--cc=clsoto@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.