From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Subject: Re: [PATCH] x86, amd_ucode: Safeguard against #GP
Date: Thu, 22 May 2014 10:59:53 -0500
Message-ID: <537E1EF9.1030601@amd.com>
References: <1400707718-3826-1-git-send-email-aravind.gopalakrishnan@amd.com>
	<537D23F3.3030607@citrix.com> <537E1D85.1030807@amd.com>
	<537E1E1D.5000601@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <537E1E1D.5000601@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: boris.ostrovsky@oracle.com, keir@xen.org, jbeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 5/22/2014 10:56 AM, Andrew Cooper wrote:
> On 22/05/14 16:53, Aravind Gopalakrishnan wrote:
>> On 5/21/2014 5:08 PM, Andrew Cooper wrote:
>>> On 21/05/2014 22:28, Aravind Gopalakrishnan wrote:
>>>> When HW tries to load a corrupted patch, it generates #GP
>>>> and hangs the system. Use wrmsr_safe instead so that we
>>>> fail to load microcode gracefully.
>>>>
>>>> Example on a Fam15h system-
>>>> (XEN) microcode: CPU0 collect_cpu_info: patch_id=0x6000626
>>>> (XEN) microcode: CPU0 size 7870, block size 2586 offset 76 equivID
>>>> 0x6012 rev 0x6000637
>>>> (XEN) microcode: CPU0 found a matching microcode update with version
>>>> 0x6000637 (current=0x6000626)
>>>> (XEN) traps.c:3073: GPF (0000): ffff82d08016f682 -> ffff82d08022d9f8
>>>> (XEN) microcode: CPU0 update from revision 0x6000637 to 0x6000626
>>>> failed
>>>>
>>>> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
>>> I suspect that you will find with a *very* up-to-date master tree, an
>>> early #GP should result in panic() instead of a hang, following
>>> 279840d5ea646  (If it doesn't I would be interested to know)
>> The console log states 'Panic on CPU0'. But system is basically hung
>> after that.
>> (attached snapshot)
> I refer you to the last line :)
>
> You have "noreboot" on your command line
>

Ah. Okay, Will try again.

Thanks,
-Aravind.