diff for duplicates of <537EA7C7.8040708@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 91c460d..c2c5254 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -27,7 +27,7 @@ On 05/23/2014 07:58 AM, 管雪涛 wrote: Thank you for your work. >> But that type check in include/asm-generic/div64.h is bogus, it should ->> be checking sizeof(X) = 8 rather than the type thing, it just wants to +>> be checking sizeof(X) == 8 rather than the type thing, it just wants to >> make sure that the value is 64-bit regardless of it's signedness. >> >> The arch local implementations do not do this, and that's why very few @@ -41,7 +41,7 @@ Yeah, we have to let do_div() no touch (especially for 32-bit machine, which the highest bit is checked). The related code in "include/asm-generic/div64.h": - 23 #if BITS_PER_LONG = 64 + 23 #if BITS_PER_LONG == 64 24 25 # define do_div(n,base) ({ \ 26 uint32_t __base = (base); \ @@ -51,7 +51,7 @@ which the highest bit is checked). The related code in 30 __rem; \ 31 }) 32 - 33 #elif BITS_PER_LONG = 32 + 33 #elif BITS_PER_LONG == 32 34 35 extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor); 36 @@ -61,8 +61,8 @@ which the highest bit is checked). The related code in 40 # define do_div(n,base) ({ \ 41 uint32_t __base = (base); \ 42 uint32_t __rem; \ - 43 (void)(((typeof((n)) *)0) = ((uint64_t *)0)); \ - 44 if (likely(((n) >> 32) = 0)) { \ + 43 (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ + 44 if (likely(((n) >> 32) == 0)) { \ 45 __rem = (uint32_t)(n) % __base; \ 46 (n) = (uint32_t)(n) / __base; \ 47 } else \ diff --git a/a/content_digest b/N1/content_digest index ee85cb6..8690d93 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,14 @@ + "ref\0263613432.57393.1400803091663.JavaMail.root@bj-mail03.pku.edu.cn\0" "From\0Chen Gang <gang.chen.5i5j@gmail.com>\0" - "Subject\0Re: \345\233\236\345\244\215\357\274\232 Re: [PATCH linux-next] net/d =?UTF-8?B?Y2NwL3RpbWVyLmM6IHVzZ\0" - "Date\0Fri, 23 May 2014 01:43:35 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Subject\0Re: \345\233\236\345\244\215\357\274\232 Re: [PATCH linux-next] net/dccp/timer.c: use 'u64' instead of 's64' to avoid compiler's warning\0" + "Date\0Fri, 23 May 2014 09:43:35 +0800\0" + "To\0\347\256\241\351\233\252\346\266\233 <gxt@pku.edu.cn>" + " David Miller <davem@davemloft.net>\0" + "Cc\0gerrit@erg.abdn.ac.uk" + gxt@mprc.pku.edu.cn + dccp@vger.kernel.org + netdev@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On 05/23/2014 07:58 AM, \347\256\241\351\233\252\346\266\233 wrote:\n" @@ -33,7 +40,7 @@ "Thank you for your work.\n" "\n" ">> But that type check in include/asm-generic/div64.h is bogus, it should\n" - ">> be checking sizeof(X) = 8 rather than the type thing, it just wants to\n" + ">> be checking sizeof(X) == 8 rather than the type thing, it just wants to\n" ">> make sure that the value is 64-bit regardless of it's signedness.\n" ">>\n" ">> The arch local implementations do not do this, and that's why very few\n" @@ -47,7 +54,7 @@ "which the highest bit is checked). The related code in\n" "\"include/asm-generic/div64.h\":\n" "\n" - " 23 #if BITS_PER_LONG = 64\n" + " 23 #if BITS_PER_LONG == 64\n" " 24\n" " 25 # define do_div(n,base) ({ \\\n" " 26 uint32_t __base = (base); \\\n" @@ -57,7 +64,7 @@ " 30 __rem; \\\n" " 31 })\n" " 32\n" - " 33 #elif BITS_PER_LONG = 32\n" + " 33 #elif BITS_PER_LONG == 32\n" " 34\n" " 35 extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);\n" " 36\n" @@ -67,8 +74,8 @@ " 40 # define do_div(n,base) ({ \\\n" " 41 uint32_t __base = (base); \\\n" " 42 uint32_t __rem; \\\n" - " 43 (void)(((typeof((n)) *)0) = ((uint64_t *)0)); \\\n" - " 44 if (likely(((n) >> 32) = 0)) { \\\n" + " 43 (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \\\n" + " 44 if (likely(((n) >> 32) == 0)) { \\\n" " 45 __rem = (uint32_t)(n) % __base; \\\n" " 46 (n) = (uint32_t)(n) / __base; \\\n" " 47 } else \\\n" @@ -87,4 +94,4 @@ "\n" Open, share, and attitude like air, water, and life which God blessed -65833d6416d33775918729f8567cf5d05ccf6bfc8f2948a9818dca6b6d95f0f7 +5f799159065754f4d92755de93abfeadc3a2caa213f95732ad95fbf469b46f93
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.