From: Andrzej Hajda <a.hajda@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/exynos: Remove duplicate inclusion of i2c.h
Date: Fri, 23 May 2014 09:47:08 +0200 [thread overview]
Message-ID: <537EFCFC.8000701@samsung.com> (raw)
In-Reply-To: <1400734976-13809-2-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On 05/22/2014 07:02 AM, Sachin Kamat wrote:
> i2c.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index ed6176e..d3f9684 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -34,7 +34,6 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> -#include <linux/i2c.h>
> #include <linux/of_gpio.h>
> #include <linux/hdmi.h>
> #include <linux/component.h>
>
It would be also good to order headers alphabetically.
Regards
Andrzej
next prev parent reply other threads:[~2014-05-23 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 5:02 [PATCH 1/3] drm/exynos: Staticize exynos_dpi_of_find_panel_node Sachin Kamat
2014-05-22 5:02 ` [PATCH 2/3] drm/exynos: Remove duplicate inclusion of i2c.h Sachin Kamat
2014-05-23 7:47 ` Andrzej Hajda [this message]
2014-05-23 7:53 ` Sachin Kamat
2014-05-22 5:02 ` [PATCH 3/3] drm/exynos: Staticize local symbols in exynos_hdmi.c Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537EFCFC.8000701@samsung.com \
--to=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.