From: Zefir Kurtisi <zefir.kurtisi@neratec.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
jim.epost@gmail.com
Subject: Re: [PATCH] ath9k: fix build error with disabled debug
Date: Fri, 23 May 2014 10:15:08 +0200 [thread overview]
Message-ID: <537F038C.7050305@neratec.com> (raw)
In-Reply-To: <877g5e3qfg.fsf@purkki.adurom.net>
On 05/22/2014 03:15 PM, Kalle Valo wrote:
> Zefir Kurtisi <zefir.kurtisi@neratec.com> writes:
>
>> DFS pulse interval printing is only available
>> when CONFIG_ATH9K_DEBUGFS is set.
>>
>> Signed-off-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath9k/dfs.c
>> +++ b/drivers/net/wireless/ath/ath9k/dfs.c
>> @@ -178,12 +178,14 @@ void ath9k_dfs_process_phyerr(struct ath_softc *sc, void *data,
>> pe.ts = mactime;
>> if (ath9k_postprocess_radar_event(sc, &ard, &pe)) {
>> struct dfs_pattern_detector *pd = sc->dfs_detector;
>> +#ifdef CONFIG_ATH9K_DEBUGFS
>
> IMHO config_enabled() is much nicer than ifdef.
>
Actually, I dislike both of them.
While this is for debug printing only, it is still a bad idea to use variables in
debugfs dependent space and splatter source code with required checks. I'll move
that into a different context and post a follow-up patch.
John, please drop this one.
next prev parent reply other threads:[~2014-05-23 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 10:40 [PATCH] ath9k: fix build error with disabled debug Zefir Kurtisi
2014-05-22 13:15 ` Kalle Valo
2014-05-23 8:15 ` Zefir Kurtisi [this message]
2014-05-23 14:40 ` John W. Linville
2014-05-23 15:22 ` [PATCH] ath9k: simplify DFS pulse interval debug printing Zefir Kurtisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537F038C.7050305@neratec.com \
--to=zefir.kurtisi@neratec.com \
--cc=jim.epost@gmail.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.