All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balaji T K <balajitk@ti.com>
To: Andreas Fenkart <afenkart@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>, Chris Ball <chris@printf.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status'
Date: Fri, 23 May 2014 13:57:48 +0530	[thread overview]
Message-ID: <537F0684.4050107@ti.com> (raw)
In-Reply-To: <CALtMJEDhBFomn8VEu1G=F8fbZBLO=msTnUCzHSpYsQxEc4WtKw@mail.gmail.com>

On Friday 23 May 2014 01:49 PM, Andreas Fenkart wrote:
> 2014-05-22 16:24 GMT+02:00 Tony Lindgren <tony@atomide.com>:
>> * Chris Ball <chris@printf.net> [140522 05:42]:
>>> Hi,
>>>
>>> On Thu, May 22 2014, Ulf Hansson wrote:
>>>> I had a second look at Andreas Fenkart's patchset to enable SDIO irq
>>>> for omap. Those needs an additional iteration, since there are
>>>> unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other
>>>> Kconfigs as well). Apparently I had all the needed Kconfigs enabled
>>>> while I compile tested them. :-(
>>
>> Did you find this out with make randconfig?
>
> FYI
>
> after this patch I could deselect CONFIG_PM
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -111,7 +111,6 @@ config ARCH_OMAP2PLUS_TYPICAL
>          select I2C_OMAP
>          select MENELAUS if ARCH_OMAP2
>          select NEON if CPU_V7
> -       select PM_RUNTIME
>          select REGULATOR
>          select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
>          select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
>
>
>>
>>>> I tried out doing a local re-base, to remove the related omap patches.
>>>> If you remove the patches below you won't get any conflicts for
>>>> omap_hsmmc. Can you do that?
>>>>
>>>> Andreas:
>>>> mmc: omap_hsmmc: Enable SDIO interrupt
>>>> mmc: omap_hsmmc: enable wakeup event for sdio OMAP4
>>>> mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state
>>>> mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected
>>>> mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks
>>>> mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x
>>>>
>>>> Balaji:
>>>> mmc: omap_hsmmc: use IS_ERR macro for error checking
>>>
>>> Done.  Thanks!
>>
>> Andreas, can you fix this ASAP? Would be nice to have those
>> working for v3.16 :)
> will send out updated patches soon

Thanks Andreas,
If it helps, how about sending the fix as separate patch,
That way it will be easier for reviewing!


      reply	other threads:[~2014-05-23  8:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <537de770.ItHqmb5BpaXWIlXq%fengguang.wu@intel.com>
2014-05-22 12:39 ` [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' Ulf Hansson
2014-05-22 12:41   ` Chris Ball
2014-05-22 14:24     ` Tony Lindgren
2014-05-23  8:19       ` Andreas Fenkart
2014-05-23  8:27         ` Balaji T K [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537F0684.4050107@ti.com \
    --to=balajitk@ti.com \
    --cc=afenkart@gmail.com \
    --cc=chris@printf.net \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.