Re: [Qemu-devel] [PATCH 1/4] Makefile: Link vscclient with libqemuutil.a and libqemustub.a

[Michael Tokarev <mjt@tls.msk.ru>]

23.05.2014 13:25, Paolo Bonzini wrote:
> Il 23/05/2014 10:26, Michael Tokarev ha scritto:
>> 23.05.2014 12:22, Paolo Bonzini wrote:
>>> Il 23/05/2014 05:02, Fam Zheng ha scritto:
>> []
>>>> -vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
>>>> +vscclient$(EXESUF): libcacard/vscclient.o libcacard.la libqemuutil.a libqemustub.a
>>>>      $(call LINK,$^)
>>>>
>>>>  #########################################################################
>>>>
>>>
>>> Michael was going to drop the dependency altogether.
>>
>> This didn't go anywhere -- after spending lots of time inventing glib
>> thread compat layer and fighting over almost moot points I gave up.
> 
> Sad.  I will pick up the work.

Here's the last incarnation:

 http://comments.gmane.org/gmane.comp.emulators.qemu/271372

The prob was re-defining GCond to GCond* in the _thin_ compat
layer I wanted to add for _old_ glib (so that all the code uses
new glib api, because that's what people know now).  That one
is fun indeed, but it allows us to go without inventing a thick
layer which will just complicate things and add unnecessary and
qemu-specific API -- to me it is too much cost for supporting
obsolete glib thread api.

FWIW, the old glib thread api is a frozen code, so we shouldn't
expect any changes in there.  And my changes does not wrap new
api (except of adding tiny wrappers for static initializers).

I've added just the libcacard conversion changes (which are
really trivial) to debian - since in debian we don't have that
old glib anymore, and I shouldn't care there about it anymore.
I tried to make it compatible with other systems too (yet
again: using the _thin_, almost non-existing, layer), but
apparently failed, and since I don't really care I gave up.

Thanks,

/mjt