Re: [PATCH v2 1/3] video: clps711x: Add new Cirrus Logic CLPS711X framebuffer driver

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On 12/04/14 09:53, Alexander Shiyan wrote:
> This adds support for the framebuffer available in the Cirrus
> Logic CLPS711X CPUs.
> FB features:
> - 1-2-4 bits per pixel.
> - Programmable panel size to a maximum of 1024x256 at 4 bps.
> - Relocatible Frame Buffer (SRAM or SDRAM).
> - Programmable refresh rates.
> - 16 gray scale values.
> This new driver supports usage with devicetree and as a general
> change it removes last user of <mach/hardware.h> for CLPS711X targets,
> so this subarch will fully prepared to switch to multiplatform.
> The driver have been tested with custom board equipped Cirrus Logic
> EP7312 in DT and non-DT mode.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/video/fbdev/clps711x-fb.c | 456 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 456 insertions(+)
>  create mode 100644 drivers/video/fbdev/clps711x-fb.c

<snip>

> +
> +static int clps711x_fb_get_mode_dt(struct platform_device *pdev)
> +{
> +	struct device_node *disp, *np = pdev->dev.of_node;
> +	struct fb_info *info = platform_get_drvdata(pdev);
> +	struct clps711x_fb_info *cfb = info->par;
> +	int ret;
> +
> +	cfb->syscon =
> +		syscon_regmap_lookup_by_compatible("cirrus,clps711x-syscon1");
> +	if (IS_ERR(cfb->syscon))
> +		return PTR_ERR(cfb->syscon);

Hmm, what's the syscon stuff about? Looks like it's required, but the DT
documentation patch doesn't mention it at all.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]