From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= Subject: Re: [PATCH 07/22] clk: sunxi: Fix PLL6 calculation on sun6i Date: Fri, 23 May 2014 10:09:01 -0300 Message-ID: <537F486D.9060900@elopez.com.ar> References: <1400831485-28576-1-git-send-email-wens@csie.org> <1400831485-28576-8-git-send-email-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from yotta.elopez.com.ar ([31.220.24.173]:33405 "EHLO yotta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbaEWNJu (ORCPT ); Fri, 23 May 2014 09:09:50 -0400 In-Reply-To: <1400831485-28576-8-git-send-email-wens@csie.org> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Chen-Yu Tsai Cc: Greg Kroah-Hartman , Samuel Ortiz , Lee Jones , Maxime Ripard , Rob Herring , Mike Turquette , Linus Walleij , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede , Boris BREZILLON , Luc Verhaegen Hi, El 23/05/14 04:51, Chen-Yu Tsai escribi=F3: > The N factor for PLL6 counts from 1 to 32, as specified in the A23 > manual, and shown in Allwinner's original code. Are you sure about this? The A23 manual I'm looking at has a 5-bit fiel= d=20 (so 0-31) on 12:8, and the examples count from 0 (eg Factor=3D0 N=3D1 .= =2E.=20 =46actor=3D31 N=3D32). Cheers, Emilio -- To unsubscribe from this list: send the line "unsubscribe linux-serial"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: emilio@elopez.com.ar (=?ISO-8859-1?Q?Emilio_L=F3pez?=) Date: Fri, 23 May 2014 10:09:01 -0300 Subject: [PATCH 07/22] clk: sunxi: Fix PLL6 calculation on sun6i In-Reply-To: <1400831485-28576-8-git-send-email-wens@csie.org> References: <1400831485-28576-1-git-send-email-wens@csie.org> <1400831485-28576-8-git-send-email-wens@csie.org> Message-ID: <537F486D.9060900@elopez.com.ar> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, El 23/05/14 04:51, Chen-Yu Tsai escribi?: > The N factor for PLL6 counts from 1 to 32, as specified in the A23 > manual, and shown in Allwinner's original code. Are you sure about this? The A23 manual I'm looking at has a 5-bit field (so 0-31) on 12:8, and the examples count from 0 (eg Factor=0 N=1 ... Factor=31 N=32). Cheers, Emilio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbaEWNJw (ORCPT ); Fri, 23 May 2014 09:09:52 -0400 Received: from yotta.elopez.com.ar ([31.220.24.173]:33405 "EHLO yotta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbaEWNJu (ORCPT ); Fri, 23 May 2014 09:09:50 -0400 Message-ID: <537F486D.9060900@elopez.com.ar> Date: Fri, 23 May 2014 10:09:01 -0300 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Chen-Yu Tsai CC: Greg Kroah-Hartman , Samuel Ortiz , Lee Jones , Maxime Ripard , Rob Herring , Mike Turquette , Linus Walleij , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede , Boris BREZILLON , Luc Verhaegen Subject: Re: [PATCH 07/22] clk: sunxi: Fix PLL6 calculation on sun6i References: <1400831485-28576-1-git-send-email-wens@csie.org> <1400831485-28576-8-git-send-email-wens@csie.org> In-Reply-To: <1400831485-28576-8-git-send-email-wens@csie.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, El 23/05/14 04:51, Chen-Yu Tsai escribió: > The N factor for PLL6 counts from 1 to 32, as specified in the A23 > manual, and shown in Allwinner's original code. Are you sure about this? The A23 manual I'm looking at has a 5-bit field (so 0-31) on 12:8, and the examples count from 0 (eg Factor=0 N=1 ... Factor=31 N=32). Cheers, Emilio