From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Fri, 23 May 2014 15:24:28 +0200 Subject: [PATCH 2/5] Documentation: dt-bindings: document the Armada 375 USB cluster binding In-Reply-To: <537F13B2.6070500@ti.com> References: <1400257376-13251-1-git-send-email-gregory.clement@free-electrons.com> <1400257376-13251-2-git-send-email-gregory.clement@free-electrons.com> <537F13B2.6070500@ti.com> Message-ID: <537F4C0C.1080901@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kishon, On 23/05/2014 11:24, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 16 May 2014 09:52 PM, Gregory CLEMENT wrote: >> Armada 375 comes with an USB2 host and device controller and an USB3 >> controller. The USB cluster control register allows to manage common >> features of both USB controllers. This commit adds the Device Tree >> binding documentation for this piece of hardware. > > Pls re-order so that the Documentation patch comes before the driver patch.. OK I will do it >> >> Signed-off-by: Gregory CLEMENT >> --- >> .../bindings/phy/armada-375-usb-phy-cluster.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt b/Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt > > simpler file name? armada-phy? I can remove the "cluster" part but not the 375, there are many SoCs from Marvell called Armada, and some of then have nearly nothing in common, so I prefer keep this name. If your intent is to have a file with all the PHY binding related to an SoC family, then we should call it mvebu-phy. Thanks for your review, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 2/5] Documentation: dt-bindings: document the Armada 375 USB cluster binding Date: Fri, 23 May 2014 15:24:28 +0200 Message-ID: <537F4C0C.1080901@free-electrons.com> References: <1400257376-13251-1-git-send-email-gregory.clement@free-electrons.com> <1400257376-13251-2-git-send-email-gregory.clement@free-electrons.com> <537F13B2.6070500@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <537F13B2.6070500-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I , Mathias Nyman , Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth Cc: Thomas Petazzoni , Ezequiel Garcia , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lior Amsalem , Tawfik Bayouk , Nadav Haklai , Grant Likely , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Kishon, On 23/05/2014 11:24, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 16 May 2014 09:52 PM, Gregory CLEMENT wrote: >> Armada 375 comes with an USB2 host and device controller and an USB3 >> controller. The USB cluster control register allows to manage common >> features of both USB controllers. This commit adds the Device Tree >> binding documentation for this piece of hardware. > > Pls re-order so that the Documentation patch comes before the driver patch.. OK I will do it >> >> Signed-off-by: Gregory CLEMENT >> --- >> .../bindings/phy/armada-375-usb-phy-cluster.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt b/Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt > > simpler file name? armada-phy? I can remove the "cluster" part but not the 375, there are many SoCs from Marvell called Armada, and some of then have nearly nothing in common, so I prefer keep this name. If your intent is to have a file with all the PHY binding related to an SoC family, then we should call it mvebu-phy. Thanks for your review, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbaEWNYl (ORCPT ); Fri, 23 May 2014 09:24:41 -0400 Received: from top.free-electrons.com ([176.31.233.9]:53927 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750981AbaEWNYj (ORCPT ); Fri, 23 May 2014 09:24:39 -0400 Message-ID: <537F4C0C.1080901@free-electrons.com> Date: Fri, 23 May 2014 15:24:28 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth CC: Thomas Petazzoni , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Lior Amsalem , Tawfik Bayouk , Nadav Haklai , Grant Likely , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH 2/5] Documentation: dt-bindings: document the Armada 375 USB cluster binding References: <1400257376-13251-1-git-send-email-gregory.clement@free-electrons.com> <1400257376-13251-2-git-send-email-gregory.clement@free-electrons.com> <537F13B2.6070500@ti.com> In-Reply-To: <537F13B2.6070500@ti.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, On 23/05/2014 11:24, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 16 May 2014 09:52 PM, Gregory CLEMENT wrote: >> Armada 375 comes with an USB2 host and device controller and an USB3 >> controller. The USB cluster control register allows to manage common >> features of both USB controllers. This commit adds the Device Tree >> binding documentation for this piece of hardware. > > Pls re-order so that the Documentation patch comes before the driver patch.. OK I will do it >> >> Signed-off-by: Gregory CLEMENT >> --- >> .../bindings/phy/armada-375-usb-phy-cluster.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt b/Documentation/devicetree/bindings/phy/armada-375-usb-phy-cluster.txt > > simpler file name? armada-phy? I can remove the "cluster" part but not the 375, there are many SoCs from Marvell called Armada, and some of then have nearly nothing in common, so I prefer keep this name. If your intent is to have a file with all the PHY binding related to an SoC family, then we should call it mvebu-phy. Thanks for your review, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com