All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>,
	"James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Wanlong Gao <gaowanlong@cn.fujitsu.com>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] virtio-scsi: replace target spinlock with seqcount
Date: Fri, 23 May 2014 15:59:52 +0200	[thread overview]
Message-ID: <537F5458.6010008@redhat.com> (raw)
In-Reply-To: <1400851712-26731-1-git-send-email-ming.lei@canonical.com>

Il 23/05/2014 15:28, Ming Lei ha scritto:
> The spinlock of tgt_lock is only for serializing read and write
> req_vq, one lockless seqcount is enough for the purpose.
>
> On one 16core VM with vhost-scsi backend, the patch can improve
> IOPS with 3% on random read test.

Nice. :)  The patch looks good, thanks for working this out!

James, I have a couple more patches planned for virtio-scsi, so I'll 
send out the update next week.

Paolo

  reply	other threads:[~2014-05-23 14:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 13:28 [PATCH] virtio-scsi: replace target spinlock with seqcount Ming Lei
2014-05-23 13:59 ` Paolo Bonzini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-27 16:50 Venkatesh Srinivas
2014-05-27 16:57 ` Paolo Bonzini
2014-05-28  1:48   ` Ming Lei
2014-05-28  8:52     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537F5458.6010008@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=JBottomley@parallels.com \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.