From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86: Expose hypervisor's PVH support via
 xen_caps
Date: Fri, 23 May 2014 16:00:23 +0100
Message-ID: <537F6287.5070705@citrix.com>
References: <1400856933-1424-1-git-send-email-boris.ostrovsky@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1400856933-1424-1-git-send-email-boris.ostrovsky@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Tim Deegan <tim@xen.org>, keir@xen.org, jbeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 23/05/14 15:55, Boris Ostrovsky wrote:
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
>  xen/arch/x86/setup.c | 5 +++++
>  1 file changed, 5 insertions(+)

If the plan is to try and PVH and HVM back into one mode as far as Xen
is concerned, doesn't this become redundant?

~Andrew

>
> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
> index b2a808a..59b31b1 100644
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -1462,6 +1462,11 @@ void arch_get_xen_caps(xen_capabilities_info_t *info)
>          safe_strcat(*info, s);
>          snprintf(s, sizeof(s), "hvm-%d.%d-x86_64 ", major, minor);
>          safe_strcat(*info, s);
> +        if ( hvm_funcs.pvh_supported )
> +        {
> +            snprintf(s, sizeof(s), "pvh-%d.%d-x86_64 ", major, minor);
> +            safe_strcat(*info, s);
> +        }
>      }
>  }
>