From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: trusted_foundations: fix compile error on non-SMP
Date: Fri, 23 May 2014 22:24:39 +0400 [thread overview]
Message-ID: <537F9267.7090304@cogentembedded.com> (raw)
In-Reply-To: <1400804612-11876-1-git-send-email-acourbot@nvidia.com>
Hello.
On 05/23/2014 04:23 AM, Alexandre Courbot wrote:
> The setup_max_cpus variable is only defined if CONFIG_SMP is set. Add
> a preprocessor condition to avoid the following compilation error if
> CONFIG_SMP is not set:
> arch/arm/include/asm/trusted_foundations.h: In function 'register_trusted_foundations':
> arch/arm/include/asm/trusted_foundations.h:57:2: error: 'setup_max_cpus' undeclared (first use in this function)
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Hi Stephen,
> This patch has been originally submitted through Russell's patch tracker,
> where it has stayed untouched for ~3 weeks now. Considering that this
> fixes a compilation error and should thus be made available quickly, and
> that Tegra is the only user of Trusted Foundations, would you agree to take
> it into your tree?
> arch/arm/include/asm/trusted_foundations.h | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/arch/arm/include/asm/trusted_foundations.h b/arch/arm/include/asm/trusted_foundations.h
> index b5f7705..624e1d4 100644
> --- a/arch/arm/include/asm/trusted_foundations.h
> +++ b/arch/arm/include/asm/trusted_foundations.h
> @@ -54,7 +54,9 @@ static inline void register_trusted_foundations(
> */
> pr_err("No support for Trusted Foundations, continuing in degraded mode.\n");
> pr_err("Secondary processors as well as CPU PM will be disabled.\n");
> +#if IS_ENABLED(CONFIG_SMP)
if (IS_ENABLED(CONFIG_SMP))
> setup_max_cpus = 0;
> +#endif
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
Stephen Warren <swarren@nvidia.com>
Cc: Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND] ARM: trusted_foundations: fix compile error on non-SMP
Date: Fri, 23 May 2014 22:24:39 +0400 [thread overview]
Message-ID: <537F9267.7090304@cogentembedded.com> (raw)
In-Reply-To: <1400804612-11876-1-git-send-email-acourbot@nvidia.com>
Hello.
On 05/23/2014 04:23 AM, Alexandre Courbot wrote:
> The setup_max_cpus variable is only defined if CONFIG_SMP is set. Add
> a preprocessor condition to avoid the following compilation error if
> CONFIG_SMP is not set:
> arch/arm/include/asm/trusted_foundations.h: In function 'register_trusted_foundations':
> arch/arm/include/asm/trusted_foundations.h:57:2: error: 'setup_max_cpus' undeclared (first use in this function)
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Hi Stephen,
> This patch has been originally submitted through Russell's patch tracker,
> where it has stayed untouched for ~3 weeks now. Considering that this
> fixes a compilation error and should thus be made available quickly, and
> that Tegra is the only user of Trusted Foundations, would you agree to take
> it into your tree?
> arch/arm/include/asm/trusted_foundations.h | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/arch/arm/include/asm/trusted_foundations.h b/arch/arm/include/asm/trusted_foundations.h
> index b5f7705..624e1d4 100644
> --- a/arch/arm/include/asm/trusted_foundations.h
> +++ b/arch/arm/include/asm/trusted_foundations.h
> @@ -54,7 +54,9 @@ static inline void register_trusted_foundations(
> */
> pr_err("No support for Trusted Foundations, continuing in degraded mode.\n");
> pr_err("Secondary processors as well as CPU PM will be disabled.\n");
> +#if IS_ENABLED(CONFIG_SMP)
if (IS_ENABLED(CONFIG_SMP))
> setup_max_cpus = 0;
> +#endif
WBR, Sergei
next prev parent reply other threads:[~2014-05-23 18:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 0:23 [PATCH RESEND] ARM: trusted_foundations: fix compile error on non-SMP Alexandre Courbot
2014-05-23 0:23 ` Alexandre Courbot
2014-05-23 16:58 ` Stephen Warren
2014-05-23 16:58 ` Stephen Warren
2014-05-23 19:28 ` Arnd Bergmann
2014-05-23 19:28 ` Arnd Bergmann
2014-05-23 18:24 ` Sergei Shtylyov [this message]
2014-05-23 18:24 ` Sergei Shtylyov
2014-05-23 19:27 ` Arnd Bergmann
2014-05-23 19:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537F9267.7090304@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.