From: Stephen Boyd <sboyd@codeaurora.org>
To: Andy Gross <agross@codeaurora.org>, Kumar Gala <galak@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [Patch v2 3/4] soc: qcom: Add GSBI driver
Date: Fri, 23 May 2014 11:52:24 -0700 [thread overview]
Message-ID: <537F98E8.6050203@codeaurora.org> (raw)
In-Reply-To: <1398357082-5102-4-git-send-email-agross@codeaurora.org>
On 04/24/14 09:31, Andy Gross wrote:
> +
> +static const struct of_device_id gsbi_dt_match[] = {
> + { .compatible = "qcom,gsbi-v1.0.0", },
> +};
Eek. This isn't NULL terminated.
-----8<---
From: Stephen Boyd <sboyd@codeaurora.org>
Subject: [PATCH] soc: qcom: Terminate gsbi of match table
Failure to terminate this match table can lead to boot failures
depending on where the compiler places the match table.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/soc/qcom/qcom_gsbi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
index 061dd0632dbd..ab7b441c9980 100644
--- a/drivers/soc/qcom/qcom_gsbi.c
+++ b/drivers/soc/qcom/qcom_gsbi.c
@@ -64,6 +64,7 @@ static int gsbi_probe(struct platform_device *pdev)
static const struct of_device_id gsbi_dt_match[] = {
{ .compatible = "qcom,gsbi-v1.0.0", },
+ { }
};
MODULE_DEVICE_TABLE(of, gsbi_dt_match);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v2 3/4] soc: qcom: Add GSBI driver
Date: Fri, 23 May 2014 11:52:24 -0700 [thread overview]
Message-ID: <537F98E8.6050203@codeaurora.org> (raw)
In-Reply-To: <1398357082-5102-4-git-send-email-agross@codeaurora.org>
On 04/24/14 09:31, Andy Gross wrote:
> +
> +static const struct of_device_id gsbi_dt_match[] = {
> + { .compatible = "qcom,gsbi-v1.0.0", },
> +};
Eek. This isn't NULL terminated.
-----8<---
From: Stephen Boyd <sboyd@codeaurora.org>
Subject: [PATCH] soc: qcom: Terminate gsbi of match table
Failure to terminate this match table can lead to boot failures
depending on where the compiler places the match table.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/soc/qcom/qcom_gsbi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
index 061dd0632dbd..ab7b441c9980 100644
--- a/drivers/soc/qcom/qcom_gsbi.c
+++ b/drivers/soc/qcom/qcom_gsbi.c
@@ -64,6 +64,7 @@ static int gsbi_probe(struct platform_device *pdev)
static const struct of_device_id gsbi_dt_match[] = {
{ .compatible = "qcom,gsbi-v1.0.0", },
+ { }
};
MODULE_DEVICE_TABLE(of, gsbi_dt_match);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-05-23 18:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 16:31 [Patch v2 0/4] Introduce drivers/soc and add QCOM GSBI driver Andy Gross
2014-04-24 16:31 ` Andy Gross
2014-04-24 16:31 ` [Patch v2 1/4] soc: Placeholder files for drivers/soc Andy Gross
2014-04-24 16:31 ` Andy Gross
2014-04-24 16:31 ` Andy Gross
2014-04-24 16:36 ` Santosh Shilimkar
2014-04-24 16:36 ` Santosh Shilimkar
2014-04-24 16:36 ` Santosh Shilimkar
2014-05-06 17:06 ` Kumar Gala
2014-05-06 17:06 ` Kumar Gala
2014-04-24 16:31 ` [Patch v2 2/4] soc: qcom: Add device tree binding for GSBI Andy Gross
2014-04-24 16:31 ` Andy Gross
2014-04-24 16:31 ` [Patch v2 3/4] soc: qcom: Add GSBI driver Andy Gross
2014-04-24 16:31 ` Andy Gross
2014-05-23 18:52 ` Stephen Boyd [this message]
2014-05-23 18:52 ` Stephen Boyd
2014-04-24 16:31 ` [Patch v2 4/4] tty: serial: msm: Remove direct access to GSBI Andy Gross
2014-04-24 16:31 ` Andy Gross
2014-04-24 16:31 ` Andy Gross
2014-05-29 15:14 ` Kumar Gala
2014-05-29 15:14 ` Kumar Gala
[not found] ` <A56B810D-869A-4E4F-BC29-C9B0F6CDCE79-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-29 15:43 ` Greg Kroah-Hartman
2014-05-29 15:43 ` Greg Kroah-Hartman
2014-05-29 15:43 ` Greg Kroah-Hartman
2014-05-29 16:05 ` Kumar Gala
2014-05-29 16:05 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537F98E8.6050203@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.