From: Alexander Duyck <alexander.h.duyck@intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com, jpirko@redhat.com
Subject: Re: [PATCH] net: Add support for device specific address syncing
Date: Fri, 23 May 2014 12:33:20 -0700 [thread overview]
Message-ID: <537FA280.7040607@intel.com> (raw)
In-Reply-To: <20140523.145535.35857476092197009.davem@davemloft.net>
On 05/23/2014 11:55 AM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> Date: Wed, 21 May 2014 13:55:15 -0700
>
>> This change provides a function to be used in order to break the
>> ndo_set_rx_mode call into a set of address add and remove calls. The code
>> is based on the implementation of dev_uc_sync/dev_mc_sync. Since they
>> essentially do the same thing but with only one dev I simply named my
>> functions __dev_uc_sync/__dev_mc_sync.
>>
>> I also implemented an unsync version of the functions as well to allow for
>> cleanup on close.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This looks fine semantically to me.
>
> Please fix the coding style issues below and submit this alongside
> the changes for whatever driver will first make use of this.
>
> Thanks!
Okay. Will do.
Thanks,
Alex
prev parent reply other threads:[~2014-05-23 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 20:55 [PATCH] net: Add support for device specific address syncing Alexander Duyck
2014-05-23 18:55 ` David Miller
2014-05-23 19:33 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537FA280.7040607@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.