From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnwTs-0003Zv-64 for qemu-devel@nongnu.org; Fri, 23 May 2014 16:54:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnwTn-0005c6-7a for qemu-devel@nongnu.org; Fri, 23 May 2014 16:54:20 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:56315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnwTn-0005bU-0X for qemu-devel@nongnu.org; Fri, 23 May 2014 16:54:15 -0400 Message-ID: <537FB574.8010709@msgid.tls.msk.ru> Date: Sat, 24 May 2014 00:54:12 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1400844279-1685-1-git-send-email-armbru@redhat.com> <537F917C.2010208@msgid.tls.msk.ru> In-Reply-To: <537F917C.2010208@msgid.tls.msk.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: alevy@redhat.com 23.05.2014 22:20, Michael Tokarev wrote: > 23.05.2014 15:24, Markus Armbruster wrote: >> Makes Coverity happy with libcacard/ (for now). >> >> v2: >> - Fix g_new() vs. g_renew() mistake in PATCH 5 [Michael Tokarev] >> - Trivially rebased > >> Markus Armbruster (7): >> libcacard/vscclient: Bury some dead code >> libcacard: Plug memory leaks around vreader_get_reader_list() >> libcacard/vreader: Drop broken recovery from failed assertion >> libcacard/vreader: Tighten assertion to clarify intent >> libcacard: Convert two leftover realloc() to GLib >> libcacard/vcard_emul_nss: Assert vreaderOpt isn't null >> libcacard/vcard_emul_nss: Drop a redundant conditional > > Reviewed-by: Michael Tokarev > > Except of the vreaderOpt assertion patch which I commented > separately. > > I think this can easily go to the -trivial tree, as all the > changes are really trivial. Including the bugfix, for which > I can send a patch myself, again, as described in my previous > reply. I applied whole series to -trivial, except of this problematic patch, for which I applied a real fix (will post in another email). Good stuff ;) Thanks, /mjt